Source/core/dom/ContainerNode.cpp - Issue 101763008: Fix some problems reported by clang static analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 101763008: Fix some problems reported by clang static analyzer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index ba1ac83c6632233c263f03136bfa2a66b2f71934..5664bd9e4f684f44513e6859349ef746e444976c 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -666,7 +666,6 @@ bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const

return false;

// What is this code really trying to do?

RenderObject* o = renderer();

- RenderObject* p = o;

if (!o->isInline() || o->isReplaced()) {

point = o->localToAbsolute(FloatPoint(), UseTransforms);

@@ -675,7 +674,7 @@ bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const

// find the next text/image child, to get a position

while (o) {

- p = o;

+ RenderObject* p = o;

if (o->firstChild()) {

o = o->firstChild();

} else if (o->nextSibling()) {

« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/editing/ApplyStyleCommand.cpp » ('j') | no next file with comments »