Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: Source/core/dom/ContainerNode.cpp

Issue 101763008: Fix some problems reported by clang static analyzer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/editing/ApplyStyleCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 clone->appendChild(n->cloneNode(true), exceptionState); 659 clone->appendChild(n->cloneNode(true), exceptionState);
660 } 660 }
661 661
662 662
663 bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const 663 bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const
664 { 664 {
665 if (!renderer()) 665 if (!renderer())
666 return false; 666 return false;
667 // What is this code really trying to do? 667 // What is this code really trying to do?
668 RenderObject* o = renderer(); 668 RenderObject* o = renderer();
669 RenderObject* p = o;
670 669
671 if (!o->isInline() || o->isReplaced()) { 670 if (!o->isInline() || o->isReplaced()) {
672 point = o->localToAbsolute(FloatPoint(), UseTransforms); 671 point = o->localToAbsolute(FloatPoint(), UseTransforms);
673 return true; 672 return true;
674 } 673 }
675 674
676 // find the next text/image child, to get a position 675 // find the next text/image child, to get a position
677 while (o) { 676 while (o) {
678 p = o; 677 RenderObject* p = o;
679 if (o->firstChild()) { 678 if (o->firstChild()) {
680 o = o->firstChild(); 679 o = o->firstChild();
681 } else if (o->nextSibling()) { 680 } else if (o->nextSibling()) {
682 o = o->nextSibling(); 681 o = o->nextSibling();
683 } else { 682 } else {
684 RenderObject* next = 0; 683 RenderObject* next = 0;
685 while (!next && o->parent()) { 684 while (!next && o->parent()) {
686 o = o->parent(); 685 o = o->parent();
687 next = o->nextSibling(); 686 next = o->nextSibling();
688 } 687 }
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
978 return true; 977 return true;
979 978
980 if (node->isElementNode() && toElement(node)->shadow()) 979 if (node->isElementNode() && toElement(node)->shadow())
981 return true; 980 return true;
982 981
983 return false; 982 return false;
984 } 983 }
985 #endif 984 #endif
986 985
987 } // namespace WebCore 986 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSGradientValue.cpp ('k') | Source/core/editing/ApplyStyleCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698