Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1016473003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android/ BUG=466848 Committed: https://crrev.com/351bf98058ce160bd3a713476f9db1e3b6029a4a Cr-Commit-Position: refs/heads/master@{#322250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_reader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/most_visited_sites.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Ted: PTAL.
5 years, 9 months ago (2015-03-25 20:01:41 UTC) #2
Ted C
lgtm
5 years, 9 months ago (2015-03-25 21:19:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016473003/1
5 years, 9 months ago (2015-03-25 21:43:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 22:27:07 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:28:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/351bf98058ce160bd3a713476f9db1e3b6029a4a
Cr-Commit-Position: refs/heads/master@{#322250}

Powered by Google App Engine
This is Rietveld 408576698