Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

Issue 1016473003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
index 4df9a29f067b32cb094d51224e2a658281ecaeaf..5a049799444721cfba47cd6f199eb568fda8e933 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
@@ -34,7 +34,7 @@ void SetFaviconTask(Profile* profile,
const GURL& page_url, const GURL& icon_url,
const std::vector<unsigned char>& image_data,
favicon_base::IconType icon_type) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<base::RefCountedMemory> bitmap_data(
new base::RefCountedBytes(image_data));
gfx::Size pixel_size(gfx::kFaviconSize, gfx::kFaviconSize);
@@ -115,7 +115,7 @@ PartnerBookmarksReader::~PartnerBookmarksReader() {}
void PartnerBookmarksReader::PartnerBookmarksCreationComplete(JNIEnv*,
jobject) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
partner_bookmarks_shim_->SetPartnerBookmarksRoot(
wip_partner_bookmarks_root_.release());
wip_next_available_id_ = 0;
@@ -126,7 +126,7 @@ void PartnerBookmarksReader::Destroy(JNIEnv* env, jobject obj) {
}
void PartnerBookmarksReader::Reset(JNIEnv* env, jobject obj) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
wip_partner_bookmarks_root_.reset();
wip_next_available_id_ = 0;
}
« no previous file with comments | « chrome/browser/android/bookmarks/bookmarks_bridge.cc ('k') | chrome/browser/android/bookmarks/partner_bookmarks_shim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698