Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 1016473003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 static const char kMappingProviderTitle[] = "provider_title"; 44 static const char kMappingProviderTitle[] = "provider_title";
45 static const char kMappingTitle[] = "mapped_title"; 45 static const char kMappingTitle[] = "mapped_title";
46 46
47 static bool g_disable_partner_bookmarks_editing = false; 47 static bool g_disable_partner_bookmarks_editing = false;
48 48
49 } // namespace 49 } // namespace
50 50
51 // static 51 // static
52 PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext( 52 PartnerBookmarksShim* PartnerBookmarksShim::BuildForBrowserContext(
53 content::BrowserContext* browser_context) { 53 content::BrowserContext* browser_context) {
54 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 54 DCHECK_CURRENTLY_ON(BrowserThread::UI);
55 55
56 PartnerBookmarksShim* data = 56 PartnerBookmarksShim* data =
57 static_cast<PartnerBookmarksShim*>( 57 static_cast<PartnerBookmarksShim*>(
58 browser_context->GetUserData(kPartnerBookmarksShimUserDataKey)); 58 browser_context->GetUserData(kPartnerBookmarksShimUserDataKey));
59 if (data) 59 if (data)
60 return data; 60 return data;
61 61
62 data = new PartnerBookmarksShim( 62 data = new PartnerBookmarksShim(
63 Profile::FromBrowserContext(browser_context)->GetPrefs()); 63 Profile::FromBrowserContext(browser_context)->GetPrefs());
64 browser_context->SetUserData(kPartnerBookmarksShimUserDataKey, data); 64 browser_context->SetUserData(kPartnerBookmarksShimUserDataKey, data);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 parent = parent->parent(); 169 parent = parent->parent();
170 } 170 }
171 return false; 171 return false;
172 } 172 }
173 173
174 const BookmarkNode* PartnerBookmarksShim::GetPartnerBookmarksRoot() const { 174 const BookmarkNode* PartnerBookmarksShim::GetPartnerBookmarksRoot() const {
175 return g_partner_model_keeper.Get().partner_bookmarks_root.get(); 175 return g_partner_model_keeper.Get().partner_bookmarks_root.get();
176 } 176 }
177 177
178 void PartnerBookmarksShim::SetPartnerBookmarksRoot(BookmarkNode* root_node) { 178 void PartnerBookmarksShim::SetPartnerBookmarksRoot(BookmarkNode* root_node) {
179 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 179 DCHECK_CURRENTLY_ON(BrowserThread::UI);
180 g_partner_model_keeper.Get().partner_bookmarks_root.reset(root_node); 180 g_partner_model_keeper.Get().partner_bookmarks_root.reset(root_node);
181 g_partner_model_keeper.Get().loaded = true; 181 g_partner_model_keeper.Get().loaded = true;
182 FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_, 182 FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_,
183 PartnerShimLoaded(this)); 183 PartnerShimLoaded(this));
184 } 184 }
185 185
186 PartnerBookmarksShim::NodeRenamingMapKey::NodeRenamingMapKey( 186 PartnerBookmarksShim::NodeRenamingMapKey::NodeRenamingMapKey(
187 const GURL& url, const base::string16& provider_title) 187 const GURL& url, const base::string16& provider_title)
188 : url_(url), provider_title_(provider_title) {} 188 : url_(url), provider_title_(provider_title) {}
189 189
190 PartnerBookmarksShim::NodeRenamingMapKey::~NodeRenamingMapKey() {} 190 PartnerBookmarksShim::NodeRenamingMapKey::~NodeRenamingMapKey() {}
191 191
192 bool operator<(const PartnerBookmarksShim::NodeRenamingMapKey& a, 192 bool operator<(const PartnerBookmarksShim::NodeRenamingMapKey& a,
193 const PartnerBookmarksShim::NodeRenamingMapKey& b) { 193 const PartnerBookmarksShim::NodeRenamingMapKey& b) {
194 return (a.url_ < b.url_) || 194 return (a.url_ < b.url_) ||
195 (a.url_ == b.url_ && a.provider_title_ < b.provider_title_); 195 (a.url_ == b.url_ && a.provider_title_ < b.provider_title_);
196 } 196 }
197 197
198 // static 198 // static
199 void PartnerBookmarksShim::ClearInBrowserContextForTesting( 199 void PartnerBookmarksShim::ClearInBrowserContextForTesting(
200 content::BrowserContext* browser_context) { 200 content::BrowserContext* browser_context) {
201 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 201 DCHECK_CURRENTLY_ON(BrowserThread::UI);
202 browser_context->SetUserData(kPartnerBookmarksShimUserDataKey, 0); 202 browser_context->SetUserData(kPartnerBookmarksShimUserDataKey, 0);
203 } 203 }
204 204
205 // static 205 // static
206 void PartnerBookmarksShim::ClearPartnerModelForTesting() { 206 void PartnerBookmarksShim::ClearPartnerModelForTesting() {
207 g_partner_model_keeper.Get().loaded = false; 207 g_partner_model_keeper.Get().loaded = false;
208 g_partner_model_keeper.Get().partner_bookmarks_root.reset(0); 208 g_partner_model_keeper.Get().partner_bookmarks_root.reset(0);
209 } 209 }
210 210
211 // static 211 // static
(...skipping 18 matching lines...) Expand all
230 return parent; 230 return parent;
231 for (int i = 0, child_count = parent->child_count(); i < child_count; ++i) { 231 for (int i = 0, child_count = parent->child_count(); i < child_count; ++i) {
232 const BookmarkNode* result = GetNodeByID(parent->GetChild(i), id); 232 const BookmarkNode* result = GetNodeByID(parent->GetChild(i), id);
233 if (result) 233 if (result)
234 return result; 234 return result;
235 } 235 }
236 return NULL; 236 return NULL;
237 } 237 }
238 238
239 void PartnerBookmarksShim::ReloadNodeMapping() { 239 void PartnerBookmarksShim::ReloadNodeMapping() {
240 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 240 DCHECK_CURRENTLY_ON(BrowserThread::UI);
241 241
242 node_rename_remove_map_.clear(); 242 node_rename_remove_map_.clear();
243 if (!prefs_) 243 if (!prefs_)
244 return; 244 return;
245 245
246 const base::ListValue* list = 246 const base::ListValue* list =
247 prefs_->GetList(prefs::kPartnerBookmarkMappings); 247 prefs_->GetList(prefs::kPartnerBookmarkMappings);
248 if (!list) 248 if (!list)
249 return; 249 return;
250 250
(...skipping 14 matching lines...) Expand all
265 NOTREACHED(); 265 NOTREACHED();
266 continue; 266 continue;
267 } 267 }
268 268
269 const NodeRenamingMapKey key(GURL(url), provider_title); 269 const NodeRenamingMapKey key(GURL(url), provider_title);
270 node_rename_remove_map_[key] = mapped_title; 270 node_rename_remove_map_[key] = mapped_title;
271 } 271 }
272 } 272 }
273 273
274 void PartnerBookmarksShim::SaveNodeMapping() { 274 void PartnerBookmarksShim::SaveNodeMapping() {
275 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 275 DCHECK_CURRENTLY_ON(BrowserThread::UI);
276 if (!prefs_) 276 if (!prefs_)
277 return; 277 return;
278 278
279 base::ListValue list; 279 base::ListValue list;
280 for (NodeRenamingMap::const_iterator i = node_rename_remove_map_.begin(); 280 for (NodeRenamingMap::const_iterator i = node_rename_remove_map_.begin();
281 i != node_rename_remove_map_.end(); 281 i != node_rename_remove_map_.end();
282 ++i) { 282 ++i) {
283 base::DictionaryValue* dict = new base::DictionaryValue(); 283 base::DictionaryValue* dict = new base::DictionaryValue();
284 dict->SetString(kMappingUrl, i->first.url().spec()); 284 dict->SetString(kMappingUrl, i->first.url().spec());
285 dict->SetString(kMappingProviderTitle, i->first.provider_title()); 285 dict->SetString(kMappingProviderTitle, i->first.provider_title());
286 dict->SetString(kMappingTitle, i->second); 286 dict->SetString(kMappingTitle, i->second);
287 list.Append(dict); 287 list.Append(dict);
288 } 288 }
289 prefs_->Set(prefs::kPartnerBookmarkMappings, list); 289 prefs_->Set(prefs::kPartnerBookmarkMappings, list);
290 } 290 }
OLDNEW
« no previous file with comments | « chrome/browser/android/bookmarks/partner_bookmarks_reader.cc ('k') | chrome/browser/android/most_visited_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698