Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

Issue 1016473003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_reader.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_reader.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 10 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
(...skipping 16 matching lines...) Expand all
27 using bookmarks::BookmarkNode; 27 using bookmarks::BookmarkNode;
28 using bookmarks::BookmarkPermanentNode; 28 using bookmarks::BookmarkPermanentNode;
29 using content::BrowserThread; 29 using content::BrowserThread;
30 30
31 namespace { 31 namespace {
32 32
33 void SetFaviconTask(Profile* profile, 33 void SetFaviconTask(Profile* profile,
34 const GURL& page_url, const GURL& icon_url, 34 const GURL& page_url, const GURL& icon_url,
35 const std::vector<unsigned char>& image_data, 35 const std::vector<unsigned char>& image_data,
36 favicon_base::IconType icon_type) { 36 favicon_base::IconType icon_type) {
37 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 37 DCHECK_CURRENTLY_ON(BrowserThread::UI);
38 scoped_refptr<base::RefCountedMemory> bitmap_data( 38 scoped_refptr<base::RefCountedMemory> bitmap_data(
39 new base::RefCountedBytes(image_data)); 39 new base::RefCountedBytes(image_data));
40 gfx::Size pixel_size(gfx::kFaviconSize, gfx::kFaviconSize); 40 gfx::Size pixel_size(gfx::kFaviconSize, gfx::kFaviconSize);
41 FaviconService* favicon_service = FaviconServiceFactory::GetForProfile( 41 FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
42 ProfileManager::GetActiveUserProfile(), 42 ProfileManager::GetActiveUserProfile(),
43 ServiceAccessType::EXPLICIT_ACCESS); 43 ServiceAccessType::EXPLICIT_ACCESS);
44 if (!favicon_service) 44 if (!favicon_service)
45 return; 45 return;
46 46
47 favicon_service->MergeFavicon( 47 favicon_service->MergeFavicon(
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 Profile* profile) 108 Profile* profile)
109 : partner_bookmarks_shim_(partner_bookmarks_shim), 109 : partner_bookmarks_shim_(partner_bookmarks_shim),
110 profile_(profile), 110 profile_(profile),
111 wip_next_available_id_(0) { 111 wip_next_available_id_(0) {
112 } 112 }
113 113
114 PartnerBookmarksReader::~PartnerBookmarksReader() {} 114 PartnerBookmarksReader::~PartnerBookmarksReader() {}
115 115
116 void PartnerBookmarksReader::PartnerBookmarksCreationComplete(JNIEnv*, 116 void PartnerBookmarksReader::PartnerBookmarksCreationComplete(JNIEnv*,
117 jobject) { 117 jobject) {
118 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 118 DCHECK_CURRENTLY_ON(BrowserThread::UI);
119 partner_bookmarks_shim_->SetPartnerBookmarksRoot( 119 partner_bookmarks_shim_->SetPartnerBookmarksRoot(
120 wip_partner_bookmarks_root_.release()); 120 wip_partner_bookmarks_root_.release());
121 wip_next_available_id_ = 0; 121 wip_next_available_id_ = 0;
122 } 122 }
123 123
124 void PartnerBookmarksReader::Destroy(JNIEnv* env, jobject obj) { 124 void PartnerBookmarksReader::Destroy(JNIEnv* env, jobject obj) {
125 delete this; 125 delete this;
126 } 126 }
127 127
128 void PartnerBookmarksReader::Reset(JNIEnv* env, jobject obj) { 128 void PartnerBookmarksReader::Reset(JNIEnv* env, jobject obj) {
129 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 129 DCHECK_CURRENTLY_ON(BrowserThread::UI);
130 wip_partner_bookmarks_root_.reset(); 130 wip_partner_bookmarks_root_.reset();
131 wip_next_available_id_ = 0; 131 wip_next_available_id_ = 0;
132 } 132 }
133 133
134 jlong PartnerBookmarksReader::AddPartnerBookmark(JNIEnv* env, 134 jlong PartnerBookmarksReader::AddPartnerBookmark(JNIEnv* env,
135 jobject obj, 135 jobject obj,
136 jstring jurl, 136 jstring jurl,
137 jstring jtitle, 137 jstring jtitle,
138 jboolean is_folder, 138 jboolean is_folder,
139 jlong parent_id, 139 jlong parent_id,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 // ---------------------------------------------------------------- 194 // ----------------------------------------------------------------
195 195
196 static jlong Init(JNIEnv* env, jobject obj) { 196 static jlong Init(JNIEnv* env, jobject obj) {
197 Profile* profile = ProfileManager::GetActiveUserProfile(); 197 Profile* profile = ProfileManager::GetActiveUserProfile();
198 PartnerBookmarksShim* partner_bookmarks_shim = 198 PartnerBookmarksShim* partner_bookmarks_shim =
199 PartnerBookmarksShim::BuildForBrowserContext(profile); 199 PartnerBookmarksShim::BuildForBrowserContext(profile);
200 PartnerBookmarksReader* reader = new PartnerBookmarksReader( 200 PartnerBookmarksReader* reader = new PartnerBookmarksReader(
201 partner_bookmarks_shim, profile); 201 partner_bookmarks_shim, profile);
202 return reinterpret_cast<intptr_t>(reader); 202 return reinterpret_cast<intptr_t>(reader);
203 } 203 }
OLDNEW
« no previous file with comments | « chrome/browser/android/bookmarks/bookmarks_bridge.cc ('k') | chrome/browser/android/bookmarks/partner_bookmarks_shim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698