Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common. (Closed)

Created:
5 years, 9 months ago by grt (UTC plus 2)
Modified:
5 years, 9 months ago
Reviewers:
sky, mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@zip2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BinaryFeatureExtractor and PEImageReader to common. This will allow them to be used from a utility process. BUG=462584 R=mattm@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/69ab18b673a13749fd4dfde40f3d04901f51016c Cr-Commit-Position: refs/heads/master@{#321484}

Patch Set 1 #

Patch Set 2 : sync to position 321353 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1224 lines) Patch
D chrome/browser/safe_browsing/binary_feature_extractor.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/safe_browsing/binary_feature_extractor.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/safe_browsing/binary_feature_extractor_posix.cc View 1 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/safe_browsing/binary_feature_extractor_unittest.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/safe_browsing/binary_feature_extractor_win.cc View 1 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/safe_browsing/binary_feature_extractor_win_unittest.cc View 1 1 chunk +0 lines, -184 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/safe_browsing/pe_image_reader_win.h View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/safe_browsing/pe_image_reader_win.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D chrome/browser/safe_browsing/pe_image_reader_win_unittest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor_posix.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/safe_browsing/pe_image_reader_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/safe_browsing/pe_image_reader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/safe_browsing/pe_image_reader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/safe_browsing/sb_sigutil.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
grt (UTC plus 2)
Hi Matt. This change is purely code motion to enable extracting features from a utility ...
5 years, 9 months ago (2015-03-19 03:44:43 UTC) #1
mattm
lgtm
5 years, 9 months ago (2015-03-19 23:13:25 UTC) #2
grt (UTC plus 2)
Thanks. Landing with TBR=sky@chromium.org for chrome.gyp and chrome/tools changes.
5 years, 9 months ago (2015-03-20 00:57:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015363003/20001
5 years, 9 months ago (2015-03-20 00:57:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 01:15:57 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 01:16:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69ab18b673a13749fd4dfde40f3d04901f51016c
Cr-Commit-Position: refs/heads/master@{#321484}

Powered by Google App Engine
This is Rietveld 408576698