chrome/common/safe_browsing/binary_feature_extractor_win.cc - Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/binary_feature_extractor_win.cc

Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: sync to position 321353 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/safe_browsing/binary_feature_extractor_unittest.cc ('k') | chrome/common/safe_browsing/binary_feature_extractor_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/safe_browsing/binary_feature_extractor_win.cc

diff --git a/chrome/browser/safe_browsing/binary_feature_extractor_win.cc b/chrome/common/safe_browsing/binary_feature_extractor_win.cc

similarity index 97%

rename from chrome/browser/safe_browsing/binary_feature_extractor_win.cc

rename to chrome/common/safe_browsing/binary_feature_extractor_win.cc

index 48b5c5ad7fb5fdd61d2a95c144aa0a2eb44ebb33..9973f263356bbfe5e490b18a943519c497248a91 100644

--- a/chrome/browser/safe_browsing/binary_feature_extractor_win.cc

+++ b/chrome/common/safe_browsing/binary_feature_extractor_win.cc

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/browser/safe_browsing/binary_feature_extractor.h"

+#include "chrome/common/safe_browsing/binary_feature_extractor.h"

#include <windows.h>

#include <softpub.h>

@@ -11,8 +11,8 @@

#include "base/files/file_path.h"

#include "base/files/memory_mapped_file.h"

#include "base/logging.h"

-#include "chrome/browser/safe_browsing/pe_image_reader_win.h"

#include "chrome/common/safe_browsing/csd.pb.h"

+#include "chrome/common/safe_browsing/pe_image_reader_win.h"

#pragma comment(lib, "wintrust.lib")