chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc - Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: sync to position 321353 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc ('k') | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

index fafc62b759c2bfb3b27b1a4fd149956d9a9e39cc..83fb01a6df205b228bec3995bb73c316e0a31b5f 100644

--- a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc

@@ -13,11 +13,11 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/install_verification/win/module_info.h"

#include "chrome/browser/install_verification/win/module_verification_common.h"

-#include "chrome/browser/safe_browsing/binary_feature_extractor.h"

#include "chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident_receiver.h"

#include "chrome/browser/safe_browsing/path_sanitizer.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

+#include "chrome/common/safe_browsing/binary_feature_extractor.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome_elf/blacklist/blacklist.h"