chrome/common/safe_browsing/binary_feature_extractor.h - Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/safe_browsing/binary_feature_extractor.h

Issue 1015363003: Move BinaryFeatureExtractor and PEImageReader to common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@zip2

Patch Set: sync to position 321353 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/safe_browsing/binary_feature_extractor.h

diff --git a/chrome/browser/safe_browsing/binary_feature_extractor.h b/chrome/common/safe_browsing/binary_feature_extractor.h

similarity index 90%

rename from chrome/browser/safe_browsing/binary_feature_extractor.h

rename to chrome/common/safe_browsing/binary_feature_extractor.h

index 4d98a1647d0882f80a71be7a1867a8bd948a9d57..73eadbf54eef5264eecebc669a192b2c5a8f43c1 100644

--- a/chrome/browser/safe_browsing/binary_feature_extractor.h

+++ b/chrome/common/safe_browsing/binary_feature_extractor.h

@@ -5,8 +5,8 @@

// Utility functions to extract file features for malicious binary detection.

// Each platform has its own implementation of this class.

-#ifndef CHROME_BROWSER_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

-#define CHROME_BROWSER_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

+#ifndef CHROME_COMMON_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

+#define CHROME_COMMON_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

#include "base/basictypes.h"

#include "base/memory/ref_counted.h"

@@ -58,4 +58,4 @@ class BinaryFeatureExtractor

};

} // namespace safe_browsing

-#endif // CHROME_BROWSER_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

+#endif // CHROME_COMMON_SAFE_BROWSING_BINARY_FEATURE_EXTRACTOR_H_

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/safe_browsing/binary_feature_extractor.cc » ('j') | no next file with comments »