Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1014993002: [exp] cc: Introduce cc::CompositorMutator. (Closed)

Created:
5 years, 9 months ago by sadrul
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[exp] cc: Introduce cc::CompositorMutator. BUG=

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -142 lines) Patch
M cc/layers/layer_unittest.cc View 2 chunks +7 lines, -15 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +1 line, -0 lines 1 comment Download
M cc/scheduler/scheduler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 6 chunks +8 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 8 chunks +35 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 5 chunks +6 lines, -0 lines 1 comment Download
M cc/trees/layer_tree_host.cc View 6 chunks +13 lines, -10 lines 1 comment Download
M cc/trees/layer_tree_host_common.h View 1 chunk +34 lines, -0 lines 1 comment Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 5 chunks +7 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 6 chunks +13 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 5 chunks +13 lines, -33 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 3 chunks +6 lines, -21 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
brianderson
https://codereview.chromium.org/1014993002/diff/1/cc/scheduler/scheduler.h File cc/scheduler/scheduler.h (right): https://codereview.chromium.org/1014993002/diff/1/cc/scheduler/scheduler.h#newcode40 cc/scheduler/scheduler.h:40: virtual void ScheduledActionCustomMutate() = 0; Maybe call this ScheduledActionStartCustomMutate() ...
5 years, 9 months ago (2015-03-19 22:23:18 UTC) #2
loyso (OOO)
https://codereview.chromium.org/1014993002/diff/1/cc/trees/layer_tree_host.cc File cc/trees/layer_tree_host.cc (right): https://codereview.chromium.org/1014993002/diff/1/cc/trees/layer_tree_host.cc#newcode431 cc/trees/layer_tree_host.cc:431: shared_bitmap_manager_, gpu_memory_buffer_manager_, compositor_mutator_, Do we want to make CompositorMutator ...
5 years, 9 months ago (2015-03-20 02:38:14 UTC) #3
loyso (OOO)
5 years, 8 months ago (2015-04-13 08:03:21 UTC) #5
https://codereview.chromium.org/1014993002/diff/1/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/1014993002/diff/1/cc/trees/layer_tree_host.h#...
cc/trees/layer_tree_host.h:448: CompositorMutator* compositor_mutator_;
JUST NOTE: This is exactly what I have here:
https://codereview.chromium.org/947033002/patch/160001/170021

1) AnimationHost is aggregated in LayerTreeHost/LayerTreeHostImpl
2) AnimationHost will eventually be decoupled via LayerTreemutators
(CompositorMutator?) abstract interface.

Powered by Google App Engine
This is Rietveld 408576698