Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1013803003: [Telemetry] Remove is_smooth flag. (Closed)

Created:
5 years, 9 months ago by eakuefner
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove is_smooth flag. This CL removes the is_smooth flag from Telemetry, and refactors existing tests and usages on a case-by-case basis to take this into account. BUG=444697 R=nednguyen,sullivan Committed: https://crrev.com/c4c9ab99eedadea3f0f6ce90ea0d3efa0e343b5a Cr-Commit-Position: refs/heads/master@{#321015}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ned's comment #

Patch Set 3 : Fix failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -194 lines) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/smooth_gesture_util_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/timeline_controller.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/alexa1-10000.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_desktop_sites.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/key_hit_test_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 6 chunks +7 lines, -7 lines 0 comments Download
M tools/perf/page_sets/key_search_mobile.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 18 chunks +23 lines, -25 lines 0 comments Download
M tools/perf/page_sets/mobile_memory.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/pathological_mobile_sites.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/polymer.py View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/simple_mobile_sites.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_10_mobile.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_25_smooth.py View 7 chunks +8 lines, -8 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 13 chunks +16 lines, -16 lines 0 comments Download
M tools/perf/page_sets/top_desktop_sites_2012Q3.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/tough_scrolling_cases.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_texture_upload_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/typical_25.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 4 chunks +3 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_test_test_case.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +12 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 1 2 6 chunks +7 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 4 chunks +13 lines, -21 lines 0 comments Download
M tools/telemetry/unittest_data/interaction_enabled_page.html View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
eakuefner
PTAL.
5 years, 9 months ago (2015-03-16 22:33:39 UTC) #1
nednguyen
lgtm https://codereview.chromium.org/1013803003/diff/1/tools/telemetry/telemetry/page/actions/action_runner_unittest.py File tools/telemetry/telemetry/page/actions/action_runner_unittest.py (right): https://codereview.chromium.org/1013803003/diff/1/tools/telemetry/telemetry/page/actions/action_runner_unittest.py#newcode54 tools/telemetry/telemetry/page/actions/action_runner_unittest.py:54: self.VerifyIssuingInteractionRecords() Test the same thing twice?
5 years, 9 months ago (2015-03-16 22:44:22 UTC) #2
eakuefner
https://codereview.chromium.org/1013803003/diff/1/tools/telemetry/telemetry/page/actions/action_runner_unittest.py File tools/telemetry/telemetry/page/actions/action_runner_unittest.py (right): https://codereview.chromium.org/1013803003/diff/1/tools/telemetry/telemetry/page/actions/action_runner_unittest.py#newcode54 tools/telemetry/telemetry/page/actions/action_runner_unittest.py:54: self.VerifyIssuingInteractionRecords() On 2015/03/16 22:44:22, nednguyen wrote: > Test the ...
5 years, 9 months ago (2015-03-16 22:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013803003/20001
5 years, 9 months ago (2015-03-17 16:47:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/44210)
5 years, 9 months ago (2015-03-17 22:18:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013803003/40001
5 years, 9 months ago (2015-03-17 22:54:12 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 23:57:46 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 23:58:56 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4c9ab99eedadea3f0f6ce90ea0d3efa0e343b5a
Cr-Commit-Position: refs/heads/master@{#321015}

Powered by Google App Engine
This is Rietveld 408576698