Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner.py

Issue 1013803003: [Telemetry] Remove is_smooth flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/action_runner.py
diff --git a/tools/telemetry/telemetry/page/actions/action_runner.py b/tools/telemetry/telemetry/page/actions/action_runner.py
index c29d1dbd7bd147940b5010d7ac23a7d8586651c7..b942b5c077b00391476de528754b029284594f3c 100644
--- a/tools/telemetry/telemetry/page/actions/action_runner.py
+++ b/tools/telemetry/telemetry/page/actions/action_runner.py
@@ -34,7 +34,7 @@ class ActionRunner(object):
action.WillRunAction(self._tab)
action.RunAction(self._tab)
- def BeginInteraction(self, label, is_smooth=False, repeatable=False):
+ def BeginInteraction(self, label, repeatable=False):
"""Marks the beginning of an interaction record.
An interaction record is a labeled time period containing
@@ -46,14 +46,11 @@ class ActionRunner(object):
Args:
label: A label for this particular interaction. This can be any
user-defined string, but must not contain '/'.
- is_smooth: Whether to check for smoothness metrics for this interaction.
repeatable: Whether other interactions may use the same logical name
as this interaction. All interactions with the same logical name must
have the same flags.
"""
flags = []
- if is_smooth:
- flags.append(timeline_interaction_record.IS_SMOOTH)
if repeatable:
flags.append(timeline_interaction_record.REPEATABLE)
@@ -61,7 +58,7 @@ class ActionRunner(object):
interaction.Begin()
return interaction
- def BeginGestureInteraction(self, label, is_smooth=False, repeatable=False):
+ def BeginGestureInteraction(self, label, repeatable=False):
"""Marks the beginning of a gesture-based interaction record.
This is similar to normal interaction record, but it will
@@ -75,12 +72,11 @@ class ActionRunner(object):
Args:
label: A label for this particular interaction. This can be any
user-defined string, but must not contain '/'.
- is_smooth: Whether to check for smoothness metrics for this interaction.
repeatable: Whether other interactions may use the same logical name
as this interaction. All interactions with the same logical name must
have the same flags.
"""
- return self.BeginInteraction('Gesture_' + label, is_smooth, repeatable)
+ return self.BeginInteraction('Gesture_' + label, repeatable)
def NavigateToPage(self, page, timeout_in_seconds=60):
"""Navigates to the given page.
« no previous file with comments | « tools/perf/page_sets/typical_25.py ('k') | tools/telemetry/telemetry/page/actions/action_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698