[Telemetry] Remove is_smooth flag.

tools/perf/page_sets/key_silk_cases.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
 from telemetry.page import page_set as page_set_module
 
 
 class KeySilkCasesPage(page_module.Page):
 
   def __init__(self, url, page_set, run_no_page_interactions):
@@ skipping 18 matching lines @@
     # overrides the PerformPageInteractions method instead of this method.
     if self._run_no_page_interactions:
       return
     self.PerformPageInteractions(action_runner)
 
   def PerformPageInteractions(self, action_runner):
     """ Perform interactions on page after navigate steps.
     Override this to define custom actions to be run after navigate steps.
     """
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollPage()
     interaction.End()
 
 
 class Page1(KeySilkCasesPage):
 
   """ Why: Infinite scroll. Brings out all of our perf issues. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page1, self).__init__(
       url='http://groupcloned.com/test/plain/list-recycle-transform.html',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(selector='#scrollable')
     interaction.End()
 
 
 class Page2(KeySilkCasesPage):
 
   """ Why: Brings out layer management bottlenecks. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page2, self).__init__(
@@ skipping 12 matching lines @@
   """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page3, self).__init__(
       # pylint: disable=C0301
       url='http://groupcloned.com/test/plain/sticky-using-webkit-backface-visibility.html',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(selector='#container')
     interaction.End()
 
 
 class Page4(KeySilkCasesPage):
 
   """
   Why: Card expansion: only the card should repaint, but in reality lots of
   storms happen.
   """
@@ skipping 186 matching lines @@
 
 class Page16(KeySilkCasesPage):
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page16, self).__init__(
       url='file://key_silk_cases/inbox_app.html?swipe_to_dismiss',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def SwipeToDismiss(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'SwipeAction', is_smooth=True)
+        'SwipeAction')
     action_runner.SwipeElement(
         left_start_ratio=0.8, top_start_ratio=0.2,
         direction='left', distance=400, speed_in_pixels_per_second=5000,
         element_function='document.getElementsByClassName("message")[2]')
     interaction.End()
 
   def PerformPageInteractions(self, action_runner):
     self.SwipeToDismiss(action_runner)
 
 
 class Page17(KeySilkCasesPage):
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page17, self).__init__(
       url='file://key_silk_cases/inbox_app.html?stress_hidey_bars',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     self.StressHideyBars(action_runner)
 
   def StressHideyBars(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(
         selector='#messages', direction='down', speed_in_pixels_per_second=200)
     interaction.End()
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(
         selector='#messages', direction='up', speed_in_pixels_per_second=200)
     interaction.End()
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(
         selector='#messages', direction='down', speed_in_pixels_per_second=200)
     interaction.End()
 
 
 class Page18(KeySilkCasesPage):
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page18, self).__init__(
       url='file://key_silk_cases/inbox_app.html?toggle_drawer',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     for _ in xrange(6):
       self.ToggleDrawer(action_runner)
 
   def ToggleDrawer(self, action_runner):
     interaction = action_runner.BeginInteraction(
-        'Action_TapAction', is_smooth=True)
+        'Action_TapAction')
     action_runner.TapElement('#menu-button')
     action_runner.Wait(1)
     interaction.End()
 
 
 class Page19(KeySilkCasesPage):
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page19, self).__init__(
       url='file://key_silk_cases/inbox_app.html?slide_drawer',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def ToggleDrawer(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'TapAction', is_smooth=True)
+        'TapAction')
     action_runner.TapElement('#menu-button')
     interaction.End()
 
-    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
+    interaction = action_runner.BeginInteraction('Wait')
     action_runner.WaitForJavaScriptCondition('''
         document.getElementById("nav-drawer").active &&
         document.getElementById("nav-drawer").children[0]
             .getBoundingClientRect().left == 0''')
     interaction.End()
 
   def RunNavigateSteps(self, action_runner):
     super(Page19, self).RunNavigateSteps(action_runner)
     action_runner.Wait(2)
     self.ToggleDrawer(action_runner)
 
   def PerformPageInteractions(self, action_runner):
     self.SlideDrawer(action_runner)
 
   def SlideDrawer(self, action_runner):
     interaction = action_runner.BeginInteraction(
-        'Action_SwipeAction', is_smooth=True)
+        'Action_SwipeAction')
     action_runner.SwipeElement(
         left_start_ratio=0.8, top_start_ratio=0.2,
         direction='left', distance=200,
         element_function='document.getElementById("nav-drawer").children[0]')
     action_runner.WaitForJavaScriptCondition(
         '!document.getElementById("nav-drawer").active')
     interaction.End()
 
 
 class Page20(KeySilkCasesPage):
 
   """ Why: Shadow DOM infinite scrolling. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page20, self).__init__(
       url='file://key_silk_cases/infinite_scrolling.html',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(
         selector='#container', speed_in_pixels_per_second=5000)
     interaction.End()
 
 
 class GwsExpansionPage(KeySilkCasesPage):
   """Abstract base class for pages that expand Google knowledge panels."""
 
   def NavigateWait(self, action_runner):
     super(GwsExpansionPage, self).RunNavigateSteps(action_runner)
     action_runner.Wait(3)
 
   def ExpandKnowledgeCard(self, action_runner):
     # expand card
     interaction = action_runner.BeginInteraction(
-        'Action_TapAction', is_smooth=True)
+        'Action_TapAction')
     action_runner.TapElement(
         element_function='document.getElementsByClassName("vk_arc")[0]')
     action_runner.Wait(2)
     interaction.End()
 
   def ScrollKnowledgeCardToTop(self, action_runner, card_id):
     # scroll until the knowledge card is at the top
     action_runner.ExecuteJavaScript(
         "document.getElementById('%s').scrollIntoView()" % card_id)
 
@@ skipping 39 matching lines @@
     self.credentials = 'google'
 
   def RunNavigateSteps(self, action_runner):
     super(Page22, self).RunNavigateSteps(action_runner)
     action_runner.WaitForJavaScriptCondition(
         'document.getElementsByClassName("fHa").length > 0')
     action_runner.Wait(2)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(selector='#mainContent')
     interaction.End()
 
 
 class Page23(KeySilkCasesPage):
 
   """
   Why: Physical simulation demo that does a lot of element.style mutation
   triggering JS and recalc slowness
   """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page23, self).__init__(
       url='http://jsbin.com/UVIgUTa/38/quiet',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollPage(
         distance_expr='window.innerHeight / 2',
         direction='down',
         use_touch=True)
     interaction.End()
-    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
+    interaction = action_runner.BeginInteraction('Wait')
     action_runner.Wait(1)
     interaction.End()
 
 
 class Page24(KeySilkCasesPage):
 
   """
   Why: Google News: this iOS version is slower than accelerated scrolling
   """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page24, self).__init__(
       url='http://mobile-news.sandbox.google.com/news/pt0?scroll',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def RunNavigateSteps(self, action_runner):
     super(Page24, self).RunNavigateSteps(action_runner)
     action_runner.WaitForJavaScriptCondition(
         'document.getElementById(":h") != null')
     action_runner.Wait(1)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollElement(
         element_function='document.getElementById(":5")',
         distance=2500,
         use_touch=True)
     interaction.End()
 
 
 class Page25(KeySilkCasesPage):
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page25, self).__init__(
       url='http://mobile-news.sandbox.google.com/news/pt0?swipe',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def RunNavigateSteps(self, action_runner):
     super(Page25, self).RunNavigateSteps(action_runner)
     action_runner.WaitForJavaScriptCondition(
         'document.getElementById(":h") != null')
     action_runner.Wait(1)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'SwipeAction', is_smooth=True)
+        'SwipeAction')
     action_runner.SwipeElement(
         direction='left', distance=100,
         element_function='document.getElementById(":f")')
     interaction.End()
-    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
+    interaction = action_runner.BeginInteraction('Wait')
     action_runner.Wait(1)
     interaction.End()
 
 
 class Page26(KeySilkCasesPage):
 
   """ Why: famo.us twitter demo """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(Page26, self).__init__(
       url='http://s.codepen.io/befamous/fullpage/pFsqb?scroll',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def RunNavigateSteps(self, action_runner):
     super(Page26, self).RunNavigateSteps(action_runner)
     action_runner.WaitForJavaScriptCondition(
         'document.getElementsByClassName("tweet").length > 0')
     action_runner.Wait(1)
 
   def PerformPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
-        'ScrollAction', is_smooth=True)
+        'ScrollAction')
     action_runner.ScrollPage(distance=5000)
     interaction.End()
 
 
 class SVGIconRaster(KeySilkCasesPage):
 
   """ Why: Mutating SVG icons; these paint storm and paint slowly. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(SVGIconRaster, self).__init__(
       url='http://wiltzius.github.io/shape-shifter/',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def RunNavigateSteps(self, action_runner):
     super(SVGIconRaster, self).RunNavigateSteps(action_runner)
     action_runner.WaitForJavaScriptCondition(
         'loaded = true')
     action_runner.Wait(1)
 
   def PerformPageInteractions(self, action_runner):
     for i in xrange(9):
       button_func = ('document.getElementById("demo").$.'
                      'buttons.children[%d]') % i
       interaction = action_runner.BeginInteraction(
-            'Action_TapAction', is_smooth=True)
+            'Action_TapAction')
       action_runner.TapElement(element_function=button_func)
       action_runner.Wait(1)
       interaction.End()
 
 
 class UpdateHistoryState(KeySilkCasesPage):
 
   """ Why: Modern apps often update history state, which currently is janky."""
 
   def __init__(self, page_set, run_no_page_interactions):
     super(UpdateHistoryState, self).__init__(
       url='file://key_silk_cases/pushState.html',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def RunNavigateSteps(self, action_runner):
     super(UpdateHistoryState, self).RunNavigateSteps(action_runner)
     action_runner.ExecuteJavaScript('''
         window.requestAnimationFrame(function() {
             window.__history_state_loaded = true;
           });
         ''')
     action_runner.WaitForJavaScriptCondition(
         'window.__history_state_loaded == true;')
 
   def PerformPageInteractions(self, action_runner):
-    interaction = action_runner.BeginInteraction('animation_interaction',
-        is_smooth=True)
+    interaction = action_runner.BeginInteraction('animation_interaction')
     action_runner.Wait(5) # JS runs the animation continuously on the page
     interaction.End()
 
 
 class SilkFinance(KeySilkCasesPage):
 
   """ Why: Some effects repaint the page, possibly including plenty of text. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(SilkFinance, self).__init__(
       url='file://key_silk_cases/silk_finance.html',
       page_set=page_set, run_no_page_interactions=run_no_page_interactions)
 
   def PerformPageInteractions(self, action_runner):
-    interaction = action_runner.BeginInteraction('animation_interaction',
-        is_smooth=True)
+    interaction = action_runner.BeginInteraction('animation_interaction')
     action_runner.Wait(10) # animation runs automatically
     interaction.End()
 
 
 class PolymerTopeka(KeySilkCasesPage):
 
   """ Why: Sample Polymer app. """
 
   def __init__(self, page_set, run_no_page_interactions):
     super(PolymerTopeka, self).__init__(
@@ skipping 98 matching lines @@
     self.AddUserStory(SVGIconRaster(self, run_no_page_interactions))
     self.AddUserStory(UpdateHistoryState(self, run_no_page_interactions))
     self.AddUserStory(SilkFinance(self, run_no_page_interactions))
     self.AddUserStory(PolymerTopeka(self, run_no_page_interactions))
 
     for page in self:
       assert (page.__class__.RunPageInteractions ==
               KeySilkCasesPage.RunPageInteractions), (
               'Pages in this page set must not override KeySilkCasesPage\' '
               'RunPageInteractions method.')