Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1013803003: [Telemetry] Remove is_smooth flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 267ef00307c5dd6a6bdad662462c3610141ac20a..6b3a60f358a81665c257fd1fb3466ad5590e09f5 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -104,13 +104,6 @@ class _TimelineBasedMetrics(object):
if not interactions:
return
- # Either all or none of the interactions should have that metric flags.
- records_custom_flags = set(interactions[0].GetUserDefinedFlags())
- for interaction in interactions[1:]:
- if records_custom_flags != set(interaction.GetUserDefinedFlags()):
- raise InvalidInteractions('Interaction records with the same logical '
- 'name must have the same flags.')
-
for metric in _GetAllTimelineBasedMetrics():
metric.AddResults(self._model, self._renderer_thread,
interactions, wrapped_results)

Powered by Google App Engine
This is Rietveld 408576698