Fix issue on <select> style change when popup is visible

Fix issue on <select> style change when popup is visible

When a user selects an item in a popup menu using the keyboard the selection is a provisional selection that isn't accepted until the popup is abandoned. The index is saved to m_acceptedIndexOnAbandon and the menulist button text is set.
When LayoutMenuList::updateFromElement() is called we need to update the menulist button text and we need to respect this provisional selection or else it looks like the selection has suddenly changed to the user.
To fix this LayoutMenuList needs to know about m_acceptedIndexOnAbandon. It turned out that the popup doesn't really care if the provisional selection or an accepted selection so I moved the provisional selection tracking to the PopupMenuClient.
LayoutMenuList needs to accept the provisional selection only when the popup was closed without accepting a selection so we add PopupMenuClient::popupDidCancel().

BUG=466004
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193034

[Xianzhu, 2015-03-18 16:46:22]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2015-03-18 16:46:23]

I like this change.

Could you also include this:
https://codereview.chromium.org/1015863002/diff/60001/LayoutTests/fast/forms/...

https://codereview.chromium.org/1013303004/diff/1/Source/web/PopupListBox.cpp
File Source/web/PopupListBox.cpp (right):

https://codereview.chromium.org/1013303004/diff/1/Source/web/PopupListBox.cpp...
Source/web/PopupListBox.cpp:256: setOriginalIndex(m_selectedIndex);
Can we have a better name for the method? The current name looks confusing.

[Xianzhu, 2015-03-23 15:52:11]

keishi@, would you like me to create a patch based on yours?

[keishi, 2015-03-24 02:07:27]

No I'm on this. I found out this patch breaks some of the PopupListBox behavior
and I'm trying to fix it.

[keishi, 2015-03-30 22:20:51]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[keishi, 2015-03-30 22:20:52]

+tkent
I think this is working now.

https://codereview.chromium.org/1013303004/diff/1/Source/web/PopupListBox.cpp
File Source/web/PopupListBox.cpp (right):

https://codereview.chromium.org/1013303004/diff/1/Source/web/PopupListBox.cpp...
Source/web/PopupListBox.cpp:256: setOriginalIndex(m_selectedIndex);
On 2015/03/18 16:46:22, Xianzhu wrote:
> Can we have a better name for the method? The current name looks confusing.

Seemed to be barely used so I removed m_originalIndex.

[tkent, 2015-03-30 23:45:34]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-03-30 23:45:34]

lgtm

[commit-bot: I haz the power, 2015-03-30 23:46:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013303004/80001

[commit-bot: I haz the power, 2015-03-31 02:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 02:39:08]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/57105)

[keishi, 2015-03-31 02:58:29]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-03-31 02:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1013303004/#ps100001
(title: "Added check for m_popup because disconnectClient may already be called
from a change event handler")

[commit-bot: I haz the power, 2015-03-31 02:59:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013303004/100001

[commit-bot: I haz the power, 2015-03-31 05:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 05:13:27]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/57128)

[keishi, 2015-04-02 04:43:47]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-04-02 04:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1013303004/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2015-04-02 04:44:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013303004/120001

[commit-bot: I haz the power, 2015-04-02 07:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 07:08:37]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/57596)

[keishi, 2015-04-02 11:55:14]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-04-02 11:55:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1013303004/#ps140001
(title: "Fixed test expectation")

[commit-bot: I haz the power, 2015-04-02 11:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1013303004/140001

[commit-bot: I haz the power, 2015-04-02 13:24:56]

Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193034