Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: Source/core/layout/LayoutMenuList.h

Issue 1013303004: Fix issue on <select> style change when popup is visible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed test expectation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/PopupMenuClient.h ('k') | Source/core/layout/LayoutMenuList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutMenuList.h
diff --git a/Source/core/layout/LayoutMenuList.h b/Source/core/layout/LayoutMenuList.h
index 3d5ce73c74b1d5a04ec160046db8693958b3a10d..7eacb077093c7c402a6df6f6a0ccd211b1c95991 100644
--- a/Source/core/layout/LayoutMenuList.h
+++ b/Source/core/layout/LayoutMenuList.h
@@ -90,10 +90,11 @@ private:
virtual int listSize() const override;
virtual int selectedIndex() const override;
virtual void popupDidHide() override;
+ virtual void popupDidCancel() override;
virtual bool itemIsSeparator(unsigned listIndex) const override;
virtual bool itemIsLabel(unsigned listIndex) const override;
virtual bool itemIsSelected(unsigned listIndex) const override;
- virtual void setTextFromItem(unsigned listIndex) override;
+ virtual void provisionalSelectionChanged(unsigned) override;
virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow = true) override;
virtual bool multiple() const override;
virtual IntRect elementRectRelativeToViewport() const override;
@@ -133,6 +134,7 @@ private:
RefPtrWillBePersistent<PopupMenu> m_popup;
bool m_popupIsVisible;
+ int m_indexToSelectOnCancel;
// TODO(tkent): Use FRIEND_TEST macro provided by gtest_prod.h
friend class LayoutMenuListTest_ElementRectRelativeToViewport_Test;
« no previous file with comments | « Source/core/html/forms/PopupMenuClient.h ('k') | Source/core/layout/LayoutMenuList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698