Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: Source/web/ExternalPopupMenuTest.cpp

Issue 1013303004: Fix issue on <select> style change when popup is visible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed test expectation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ExternalPopupMenuTest.cpp
diff --git a/Source/web/ExternalPopupMenuTest.cpp b/Source/web/ExternalPopupMenuTest.cpp
index 20a58206bfa53bb7a525edc3e9edf18a75b8c33d..c9e2e49b6482eff3a762fc25261c16f824236143 100644
--- a/Source/web/ExternalPopupMenuTest.cpp
+++ b/Source/web/ExternalPopupMenuTest.cpp
@@ -58,10 +58,11 @@ public:
virtual int listSize() const override { return m_listSize; }
virtual int selectedIndex() const override { return 0; }
virtual void popupDidHide() override { }
+ virtual void popupDidCancel() override { }
virtual bool itemIsSeparator(unsigned listIndex) const override { return false;}
virtual bool itemIsLabel(unsigned listIndex) const override { return false; }
virtual bool itemIsSelected(unsigned listIndex) const override { return listIndex == 0;}
- virtual void setTextFromItem(unsigned listIndex) override { }
+ virtual void provisionalSelectionChanged(unsigned listIndex) override { }
virtual bool multiple() const override { return false; }
virtual IntRect elementRectRelativeToViewport() const override { return IntRect(); }
virtual Element& ownerElement() const override { return *m_ownerElement; }
« no previous file with comments | « Source/core/layout/LayoutMenuList.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698