Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 101143005: Add deprecation warnings for CSSValue accessors. (Closed)

Created:
6 years, 11 months ago by eseidel
Modified:
6 years, 11 months ago
Reviewers:
ojan
CC:
blink-reviews, krit, arv+blink, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, pdr, f(malita), Stephen Chennney, watchdog-blink-watchlist_google.com, rwlbuis, pdr., ojan
Visibility:
Public.

Description

Add deprecation warnings for CSSValue accessors. CSSValue and friends were deprecated by the W3C over a decade ago! http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html A new CSSOM is in the works: http://dev.w3.org/csswg/cssom/ BUG=331608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164897

Patch Set 1 #

Patch Set 2 : Only measure getPropertyCSSValue for now, fix LayoutTests for deprecation message of getPresentatio… #

Patch Set 3 : rebased #

Patch Set 4 : Add Mac NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/getPresentationAttribute-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/svg/custom/path-getPresentationAttribute-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
eseidel
Unfortunately thousands of layout tests use getPropertyCSSValue() (many unnecessarily) and will need to be updated ...
6 years, 11 months ago (2014-01-04 00:36:17 UTC) #1
krit
There is no successor for CSSValue yet. CSSOM the spec barely specifies what browsers agreed ...
6 years, 11 months ago (2014-01-04 06:40:09 UTC) #2
eseidel
Do you have more information about ie adopting this method? On Friday, January 3, 2014, ...
6 years, 11 months ago (2014-01-07 05:31:16 UTC) #3
eseidel
http://msdn.microsoft.com/en-us/library/ff460662(v=vs.85).aspx pretty clearly states that all known versions of IE don't support this method or ...
6 years, 11 months ago (2014-01-07 07:47:32 UTC) #4
eseidel
This should actually pass the layout tests and be ready for real review now.
6 years, 11 months ago (2014-01-07 20:11:13 UTC) #5
ojan
lgtm
6 years, 11 months ago (2014-01-07 20:18:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/101143005/110001
6 years, 11 months ago (2014-01-07 20:18:21 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=14665
6 years, 11 months ago (2014-01-08 01:33:30 UTC) #8
eseidel
I think mac has custom baselines for this test. I'll just need to mark it ...
6 years, 11 months ago (2014-01-08 01:39:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/101143005/290001
6 years, 11 months ago (2014-01-10 18:35:09 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 20:00:41 UTC) #11
Message was sent while issue was closed.
Change committed as 164897

Powered by Google App Engine
This is Rietveld 408576698