Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: Source/core/css/CSSStyleDeclaration.idl

Issue 101143005: Add deprecation warnings for CSSValue accessors. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add Mac NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSStyleDeclaration.idl
diff --git a/Source/core/css/CSSStyleDeclaration.idl b/Source/core/css/CSSStyleDeclaration.idl
index f552573a8eba3ae8ad6c25096f4f4bb3e88af612..86cfc433e702ea40d39b321f9b55a578134f2e18 100644
--- a/Source/core/css/CSSStyleDeclaration.idl
+++ b/Source/core/css/CSSStyleDeclaration.idl
@@ -25,7 +25,6 @@
[TreatReturnedNullStringAs=Null, TreatNullAs=NullString, RaisesException=Setter] attribute DOMString cssText;
[TreatReturnedNullStringAs=Null] DOMString getPropertyValue([Default=Undefined] optional DOMString propertyName);
- CSSValue getPropertyCSSValue([Default=Undefined] optional DOMString propertyName);
[TreatReturnedNullStringAs=Null, RaisesException] DOMString removeProperty([Default=Undefined] optional DOMString propertyName);
[TreatReturnedNullStringAs=Null] DOMString getPropertyPriority([Default=Undefined] optional DOMString propertyName);
[RaisesException] void setProperty([Default=Undefined] optional DOMString propertyName,
@@ -38,5 +37,10 @@
[Custom] setter void (DOMString propertyName, [TreatNullAs=NullString] DOMString propertyValue);
readonly attribute CSSRule parentRule;
[RuntimeEnabled=CSSVariables] readonly attribute CSSVariablesMap var;
+
+ // Deprecated as of 2003: http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html
+ // FIXME: This should be DeprecateAs=, but currently too many LayoutTests use
+ // this function and would need CONSOLE: message rebaselines!
+ [MeasureAs=CSSStyleDeclarationGetPropertyCSSValue] CSSValue getPropertyCSSValue([Default=Undefined] optional DOMString propertyName);
};
« no previous file with comments | « LayoutTests/svg/custom/path-getPresentationAttribute-crash-expected.txt ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698