Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 101143005: Add deprecation warnings for CSSValue accessors. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add Mac NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/svg/SVGElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 678
679 case ShowModalDialog: 679 case ShowModalDialog:
680 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead."; 680 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";
681 681
682 case CSSStyleSheetInsertRuleOptionalArg: 682 case CSSStyleSheetInsertRuleOptionalArg:
683 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0)."; 683 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
684 684
685 case AttributeSpecified: 685 case AttributeSpecified:
686 return "Attr.specified is deprecated. Its value is always true."; 686 return "Attr.specified is deprecated. Its value is always true.";
687 687
688 case SVGElementGetPresentationAttribute:
689 return "CSSValue and SVGElement.getPresentationAttribute are deprecated. Please use getPropertyValue and parse the return value instead.";
690
688 // Features that aren't deprecated don't have a deprecation message. 691 // Features that aren't deprecated don't have a deprecation message.
689 default: 692 default:
690 return String(); 693 return String();
691 } 694 }
692 } 695 }
693 696
694 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 697 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
695 { 698 {
696 ASSERT(feature >= firstCSSProperty); 699 ASSERT(feature >= firstCSSProperty);
697 ASSERT(feature <= lastCSSProperty); 700 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
726 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 729 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
727 { 730 {
728 // FIXME: We may want to handle stylesheets that have multiple owners 731 // FIXME: We may want to handle stylesheets that have multiple owners
729 // http://crbug.com/242125 732 // http://crbug.com/242125
730 if (sheetContents && sheetContents->hasSingleOwnerNode()) 733 if (sheetContents && sheetContents->hasSingleOwnerNode())
731 return getFrom(sheetContents->singleOwnerDocument()); 734 return getFrom(sheetContents->singleOwnerDocument());
732 return 0; 735 return 0;
733 } 736 }
734 737
735 } // namespace WebCore 738 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/core/svg/SVGElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698