[Telemetry] Remove is_respsonsive flag.

[Telemetry] Remove is_respsonsive flag.

BUG=444697
Committed: https://crrev.com/109d025eefa2952f8294c93f407e3f283265b7c0
Cr-Commit-Position: refs/heads/master@{#320744}

[nednguyen, 2015-03-14 17:18:07]

Patchset #1 (id:1) has been deleted

[nednguyen, 2015-03-14 17:23:19]

Patchset #1 (id:20001) has been deleted

[nednguyen, 2015-03-14 23:13:58]

Patchset #1 (id:40001) has been deleted

[nednguyen, 2015-03-16 14:49:13]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org, sullivan@chromium.org

[nednguyen, 2015-03-16 14:49:14]

sull

[sullivan, 2015-03-16 14:58:30]

lgtm, but based on my question I think Ethan should take a look too.

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py
(right):

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py:18:
'cat', 'Interaction.%s' % name,
Do these names get propogated to the dashboard at all? Are there going to be
timeseries with "is_responseive" in them that get renamed?

[nednguyen, 2015-03-16 15:01:02]

On 2015/03/16 14:58:30, sullivan wrote:
> lgtm, but based on my question I think Ethan should take a look too.
> 
>
https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
> File
> tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py
> (right):
> 
>
https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
>
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py:18:
> 'cat', 'Interaction.%s' % name,
> Do these names get propogated to the dashboard at all? Are there going to be
> timeseries with "is_responseive" in them that get renamed?

There is no interaction with the "is_respsonsive" tag in perf/. Also we don't
populate these flags in the value object, so it shouldn't matter anyway.

[eakuefner, 2015-03-16 15:20:28]

lgtm

Ned, do you want help removing IS_SMOOTH? It will probably be a larger change
since I think we do use it in tools/perf but I'm willing to work on it if you
haven't started already.

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py
(right):

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py:18:
'cat', 'Interaction.%s' % name,
On 2015/03/16 14:58:30, sullivan wrote:
> Do these names get propogated to the dashboard at all? Are there going to be
> timeseries with "is_responseive" in them that get renamed?

What Ned said is correct -- we actually strip marker-name niceties using a regex
[1], which means that label names will be only the part after the dot and before
the optional slash.

Ned, do you want to add a TODO at [1] to fix the regex once we get rid of these
flags?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
w

[nednguyen, 2015-03-16 16:12:10]

On 2015/03/16 15:20:28, eakuefner wrote:
> lgtm
> 
> Ned, do you want help removing IS_SMOOTH? It will probably be a larger change
> since I think we do use it in tools/perf but I'm willing to work on it if you
> haven't started already.
This would be awesome! Thanks Ethan!

> 
>
https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
> File
> tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py
> (right):
> 
>
https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
>
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py:18:
> 'cat', 'Interaction.%s' % name,
> On 2015/03/16 14:58:30, sullivan wrote:
> > Do these names get propogated to the dashboard at all? Are there going to be
> > timeseries with "is_responseive" in them that get renamed?
> 
> What Ned said is correct -- we actually strip marker-name niceties using a
regex
> [1], which means that label names will be only the part after the dot and
before
> the optional slash.
> 
> Ned, do you want to add a TODO at [1] to fix the regex once we get rid of
these
> flags?
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> w

[nednguyen, 2015-03-16 16:12:17]

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py
(right):

https://codereview.chromium.org/1007583002/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py:18:
'cat', 'Interaction.%s' % name,
On 2015/03/16 15:20:28, eakuefner wrote:
> On 2015/03/16 14:58:30, sullivan wrote:
> > Do these names get propogated to the dashboard at all? Are there going to be
> > timeseries with "is_responseive" in them that get renamed?
> 
> What Ned said is correct -- we actually strip marker-name niceties using a
regex
> [1], which means that label names will be only the part after the dot and
before
> the optional slash.
> 
> Ned, do you want to add a TODO at [1] to fix the regex once we get rid of
these
> flags?
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> w

I don't think we will get rid of all flags. At least, the "repeatable" will
still stay there :)

[nednguyen, 2015-03-16 16:12:20]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-03-16 16:12:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007583002/60001

[commit-bot: I haz the power, 2015-03-16 17:30:25]

Committed patchset #1 (id:60001)

[commit-bot: I haz the power, 2015-03-16 17:31:25]

Patchset 1 (id:??) landed as
https://crrev.com/109d025eefa2952f8294c93f407e3f283265b7c0
Cr-Commit-Position: refs/heads/master@{#320744}