tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 1007583002: [Telemetry] Remove is_respsonsive flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 1007583002: [Telemetry] Remove is_respsonsive flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py ('K') | « tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py ('k') | tools/telemetry/telemetry/web_perf/timeline_interaction_record.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index fe7971b45112765604764f9e2c828c00c7086933..043bdd10881cf0a3a19aa3ab0753f795078cbdc1 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -116,7 +116,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):

d.AddInteraction(d.renderer_thread, ts=0, duration=20,

marker='Interaction.LogicalName1/is_smooth')

d.AddInteraction(d.renderer_thread, ts=25, duration=5,

- marker='Interaction.LogicalName2/is_responsive')

+ marker='Interaction.LogicalName2/')

d.AddInteraction(d.foo_thread, ts=50, duration=15,

marker='Interaction.LogicalName3/is_smooth')

d.FinalizeImport()

@@ -131,7 +131,6 @@ class TimelineBasedMetricsTests(unittest.TestCase):

self.assertEquals(0, interactions[0].start)

self.assertEquals(20, interactions[0].end)

- self.assertTrue(interactions[1].is_responsive)

self.assertEquals(25, interactions[1].start)

self.assertEquals(30, interactions[1].end)

@@ -148,7 +147,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):

d.AddInteraction(d.renderer_thread, ts=0, duration=20,

marker='Interaction.LogicalName1/is_smooth')

d.AddInteraction(d.foo_thread, ts=25, duration=5,

- marker='Interaction.LogicalName2/is_responsive')

+ marker='Interaction.LogicalName2')

d.FinalizeImport()

d.AddResults()

self.assertEquals(1, len(d.results.FindAllPageSpecificValuesNamed(

@@ -195,7 +194,7 @@ class TimelineBasedMetricsTests(unittest.TestCase):

def testDuplicateRepeatableInteractionsWithDifferentMetrics(self):

d = TimelineBasedMetricTestData()

- responsive_marker = 'Interaction.LogicalName/is_responsive,repeatable'

+ responsive_marker = 'Interaction.LogicalName/repeatable'

d.AddInteraction(

d.renderer_thread, ts=10, duration=5, marker=responsive_marker)

smooth_marker = 'Interaction.LogicalName/is_smooth,repeatable'