Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_interaction_record.py

Issue 1007583002: [Telemetry] Remove is_respsonsive flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py b/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
index 8b43909f04afc5c78814c0e9c11397c6fc99ab5a..947e74f462cdab98b93fcaae3fa43e7f020c781f 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
@@ -7,15 +7,12 @@ import re
import telemetry.timeline.bounds as timeline_bounds
from telemetry import decorators
-# Enables the responsiveness metric for this interaction
-IS_RESPONSIVE = 'is_responsive'
# Enables the smoothness metric for this interaction
IS_SMOOTH = 'is_smooth'
# Allows multiple duplicate interactions of the same type
REPEATABLE = 'repeatable'
METRICS = [
- IS_RESPONSIVE,
IS_SMOOTH
]
FLAGS = METRICS + [REPEATABLE]
@@ -85,7 +82,7 @@ class TimelineInteractionRecord(object):
is currently done by pushing markers into the console.time/timeEnd API: this
for instance can be issued in JS:
- var str = 'Interaction.SendEmail/is_smooth,is_responsive';
+ var str = 'Interaction.SendEmail/is_smooth';
console.time(str);
setTimeout(function() {
console.timeEnd(str);
@@ -97,7 +94,6 @@ class TimelineInteractionRecord(object):
time-range.
The valid interaction flags are:
- * is_responsive: Enables the responsiveness metric
* is_smooth: Enables the smoothness metric
* repeatable: Allows other interactions to use the same label
"""
@@ -124,10 +120,6 @@ class TimelineInteractionRecord(object):
return self._end
@property
- def is_responsive(self):
- return IS_RESPONSIVE in self._flags
-
- @property
def is_smooth(self):
return IS_SMOOTH in self._flags

Powered by Google App Engine
This is Rietveld 408576698