[Telemetry] Remove is_respsonsive flag.

tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
 from telemetry.timeline import model as model_module
 from telemetry.timeline import async_slice
 from telemetry.web_perf import timeline_interaction_record as tir_module
 from telemetry.web_perf.metrics import mainthread_jank_stats
 
 
 class MainthreadJankTests(unittest.TestCase):
 
   def CreateTestRecord(self, name, start, end, thread_start, thread_end,
                        parent_thread):
     s = async_slice.AsyncSlice(
-        'cat', 'Interaction.%s/is_responsive' % name,
+        'cat', 'Interaction.%s' % name,

[sullivan, 2015/03/16 14:58:30]

Do these names get propogated to the dashboard at all? Are there going to be
timeseries with "is_responseive" in them that get renamed?

[eakuefner, 2015/03/16 15:20:28]

What Ned said is correct -- we actually strip marker-name niceties using a regex
[1], which means that label names will be only the part after the dot and before
the optional slash.

Ned, do you want to add a TODO at [1] to fix the regex once we get rid of these
flags?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
w

[nednguyen, 2015/03/16 16:12:17]

I don't think we will get rid of all flags. At least, the "repeatable" will
still stay there :)

         timestamp=start, duration=end - start, start_thread=parent_thread,
         end_thread=parent_thread, thread_start=thread_start,
         thread_duration=thread_end - thread_start)
     return tir_module.TimelineInteractionRecord.FromAsyncEvent(s)
 
   def testComputeMainthreadJankStatsForRecord(self):
     # The slice hierarchy should look something like this:
     # [  MessageLoop::RunTask   ] [MessageLoop::RunTask][  MessagLoop::RunTask ]
     #                                 [ foo ]                  [ bar ]
     #            |                                                |
@@ skipping 80 matching lines @@
     ]
 
     stats = mainthread_jank_stats.MainthreadJankStats(
         renderer_main, test_records)
     # Main thread janks covered by records' ranges are:
     # Record 1: (40ms -> 70ms)
     # Record 2: (120ms -> 200ms)
     # Record 3: (220ms -> 400ms), (450ms -> 750ms)
     self.assertEquals(560, stats.total_big_jank_thread_time)
     self.assertEquals(300, stats.biggest_jank_thread_time)