Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Yuki, bashi
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() As v8::Local<v8::Value> is passed as value everywhere, sync the NativeValueTraits<T>::nativeValue signature. R=yukishiino@chromium.org, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/NativeValueTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.h View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestPermissiveDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/UnionTypesModules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/UnionTypesModules.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-16 13:14:56 UTC) #2
Yuki
lgtm
5 years, 9 months ago (2015-03-16 13:19:56 UTC) #4
vivekg
On 2015/03/16 at 13:19:56, yukishiino wrote: > lgtm Thank you.
5 years, 9 months ago (2015-03-16 13:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006323002/1
5 years, 9 months ago (2015-03-16 13:20:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191920
5 years, 9 months ago (2015-03-16 14:41:40 UTC) #8
haraken
5 years, 9 months ago (2015-03-16 23:22:13 UTC) #9
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698