Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/templates/union.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY! 5 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "{{v8_original_class}}.h" 8 #include "{{v8_original_class}}.h"
9 9
10 {% for filename in cpp_includes if filename != '%s.h' % v8_class %} 10 {% for filename in cpp_includes if filename != '%s.h' % v8_class %}
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 dictionary->Set(v8String(isolate, "{{member.name}}"), {{member.cpp_value _to_v8_value}}); 100 dictionary->Set(v8String(isolate, "{{member.name}}"), {{member.cpp_value _to_v8_value}});
101 {% if member.v8_default_value %} 101 {% if member.v8_default_value %}
102 } else { 102 } else {
103 dictionary->Set(v8String(isolate, "{{member.name}}"), {{member.v8_defaul t_value}}); 103 dictionary->Set(v8String(isolate, "{{member.name}}"), {{member.v8_defaul t_value}});
104 {% endif %} 104 {% endif %}
105 } 105 }
106 106
107 {% endfor %} 107 {% endfor %}
108 } 108 }
109 109
110 {{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(const v8::Local<v8:: Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState) 110 {{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Local<v8::Value> value, v8::Isolate* isolate, ExceptionState& exceptionState)
111 { 111 {
112 {{cpp_class}} impl; 112 {{cpp_class}} impl;
113 {{v8_class}}::toImpl(isolate, value, impl, exceptionState); 113 {{v8_class}}::toImpl(isolate, value, impl, exceptionState);
114 return impl; 114 return impl;
115 } 115 }
116 116
117 } // namespace blink 117 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/templates/dictionary_v8.h ('k') | Source/bindings/templates/union.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698