Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: Source/bindings/templates/union.cpp

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/union.h ('k') | Source/bindings/tests/results/core/UnionTypesCore.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/union.cpp
diff --git a/Source/bindings/templates/union.cpp b/Source/bindings/templates/union.cpp
index 53670a68e20db44aedb0d08c3a6dbbd1a2c07e6d..73c466f0f45d814eb9ac56aa3206aca75b403a5e 100644
--- a/Source/bindings/templates/union.cpp
+++ b/Source/bindings/templates/union.cpp
@@ -184,7 +184,7 @@ v8::Local<v8::Value> toV8(const {{container.cpp_class}}& impl, v8::Local<v8::Obj
return v8::Local<v8::Value>();
}
-{{container.cpp_class}} NativeValueTraits<{{container.cpp_class}}>::nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
+{{container.cpp_class}} NativeValueTraits<{{container.cpp_class}}>::nativeValue(v8::Local<v8::Value> value, v8::Isolate* isolate, ExceptionState& exceptionState)
{
{{container.cpp_class}} impl;
V8{{container.cpp_class}}::toImpl(isolate, value, impl, exceptionState);
« no previous file with comments | « Source/bindings/templates/union.h ('k') | Source/bindings/tests/results/core/UnionTypesCore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698