Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: Source/bindings/modules/v8/V8BindingForModules.h

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/modules/v8/V8BindingForModules.h
diff --git a/Source/bindings/modules/v8/V8BindingForModules.h b/Source/bindings/modules/v8/V8BindingForModules.h
index c40a4b97f3e9b5c91a378e2bb070baf3abc75fc9..5cfecbce82f6d58578e80ea2e0ba05ec97515cc6 100644
--- a/Source/bindings/modules/v8/V8BindingForModules.h
+++ b/Source/bindings/modules/v8/V8BindingForModules.h
@@ -32,17 +32,17 @@ void assertPrimaryKeyValidOrInjectable(ScriptState*, PassRefPtr<SharedBuffer>, c
template <>
struct NativeValueTraits<SQLValue> {
- static SQLValue nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
+ static SQLValue nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
};
template <>
struct NativeValueTraits<IDBKey*> {
- static IDBKey* nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
+ static IDBKey* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
};
template <>
struct NativeValueTraits<IDBKeyRange*> {
- static IDBKeyRange* nativeValue(const v8::Local<v8::Value>&, v8::Isolate*, ExceptionState&);
+ static IDBKeyRange* nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
};
} // namespace blink
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698