Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1005903004: Revert of Refactor serving_dirs. (Closed)

Created:
5 years, 9 months ago by vangelis
Modified:
5 years, 9 months ago
CC:
tonyg, chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor serving_dirs. (patchset #7 id:110001 of https://codereview.chromium.org/838253005/) Reason for revert: Causing failures on GPU bots http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/30080 Original issue's description: > Refactor serving_dirs with two goals in mind: > > 1) Move the serving_dir related logic to one place and add some comments to improve hackability and stability for cloud_storage in telemetry. > > 2) Make serving_dirs available for user stories as part of the refactor to remove page_sets. > > This is the second part of https://codereview.chromium.org/794493004/, broken out for reviewer ease. > > BUG=454531 > BUG=435063 > > Committed: https://crrev.com/eed596dced7b9e3f7d21c84f695a39b946c62bf2 > Cr-Commit-Position: refs/heads/master@{#320523} TBR=dtu@chromium.org,sullivan@chromium.org,nednguyen@google.com,chrishenry@google.com,dpranke@chromium.org,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454531 Committed: https://crrev.com/c624e3576c93717d2f670a5df930b9cd1f2625f7 Cr-Commit-Position: refs/heads/master@{#320543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -305 lines) Patch
M tools/telemetry/telemetry/page/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub.py View 6 chunks +0 lines, -29 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub_unittest.py View 4 chunks +101 lines, -122 lines 0 comments Download
M tools/telemetry/telemetry/user_story/__init__.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 4 chunks +25 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 2 chunks +1 line, -8 lines 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage.py View 3 chunks +4 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage_unittest.py View 3 chunks +1 line, -107 lines 0 comments Download
M tools/telemetry/telemetry/util/find_dependencies.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vangelis
Created Revert of Refactor serving_dirs.
5 years, 9 months ago (2015-03-13 19:06:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005903004/1
5 years, 9 months ago (2015-03-13 19:06:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 19:07:11 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 19:07:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c624e3576c93717d2f670a5df930b9cd1f2625f7
Cr-Commit-Position: refs/heads/master@{#320543}

Powered by Google App Engine
This is Rietveld 408576698