Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1603)

Side by Side Diff: tools/telemetry/telemetry/page/page_set_unittest.py

Issue 1005903004: Revert of Refactor serving_dirs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import tempfile 6 import tempfile
7 import unittest 7 import unittest
8 8
9 from telemetry.page import page 9 from telemetry.page import page
10 from telemetry.page import page_set 10 from telemetry.page import page_set
11 from telemetry.util import cloud_storage 11 from telemetry.util import cloud_storage
12 12
13 13
14 class TestPageSet(unittest.TestCase): 14 class TestPageSet(unittest.TestCase):
15 15
16 def testServingDirs(self): 16 def testServingDirs(self):
17 directory_path = tempfile.mkdtemp() 17 directory_path = tempfile.mkdtemp()
18 try: 18 try:
19 ps = page_set.PageSet(serving_dirs=['a/b'], file_path=directory_path) 19 ps = page_set.PageSet(serving_dirs=['a/b'], file_path=directory_path)
20 ps.AddUserStory(page.Page('file://c/test.html', ps, ps.base_dir)) 20 ps.AddUserStory(page.Page('file://c/test.html', ps, ps.base_dir))
21 ps.AddUserStory(page.Page('file://c/test.js', ps, ps.base_dir)) 21 ps.AddUserStory(page.Page('file://c/test.js', ps, ps.base_dir))
22 ps.AddUserStory(page.Page('file://d/e/../test.html', ps, ps.base_dir)) 22 ps.AddUserStory(page.Page('file://d/e/../test.html', ps, ps.base_dir))
23 finally: 23 finally:
24 os.rmdir(directory_path) 24 os.rmdir(directory_path)
25 25
26 real_directory_path = os.path.realpath(directory_path) 26 real_directory_path = os.path.realpath(directory_path)
27 expected_serving_dirs = set([os.path.join(real_directory_path, 'a', 'b'), 27 expected_serving_dirs = set([os.path.join(real_directory_path, 'a', 'b')])
28 os.path.join(real_directory_path, 'c'),
29 os.path.join(real_directory_path, 'd')])
30 self.assertEquals(ps.serving_dirs, expected_serving_dirs) 28 self.assertEquals(ps.serving_dirs, expected_serving_dirs)
31 self.assertEquals(ps[0].serving_dir, os.path.join(real_directory_path, 'c')) 29 self.assertEquals(ps[0].serving_dir, os.path.join(real_directory_path, 'c'))
32 self.assertEquals(ps[2].serving_dir, os.path.join(real_directory_path, 'd')) 30 self.assertEquals(ps[2].serving_dir, os.path.join(real_directory_path, 'd'))
33 31
34 def testAbsoluteServingDir(self): 32 def testAbsoluteServingDir(self):
35 directory_path = tempfile.mkdtemp() 33 directory_path = tempfile.mkdtemp()
36 try: 34 try:
37 absolute_dir = os.path.join(directory_path, 'a', 'b') 35 absolute_dir = os.path.join(directory_path, 'a', 'b')
38 ps = page_set.PageSet(file_path=directory_path, 36 ps = page_set.PageSet(file_path=directory_path,
39 serving_dirs=['', directory_path, absolute_dir]) 37 serving_dirs=['', directory_path, absolute_dir])
(...skipping 17 matching lines...) Expand all
57 page_set_b = page_set.PageSet() 55 page_set_b = page_set.PageSet()
58 for p in pages: 56 for p in pages:
59 p.TransferToPageSet(page_set_b) 57 p.TransferToPageSet(page_set_b)
60 page_set_b.AddUserStory(page.Page('http://baz.com', page_set_b)) 58 page_set_b.AddUserStory(page.Page('http://baz.com', page_set_b))
61 self.assertEqual(0, len(page_set_a.pages)) 59 self.assertEqual(0, len(page_set_a.pages))
62 self.assertEqual( 60 self.assertEqual(
63 set(['http://foo.com', 'http://bar.com', 'http://baz.com']), 61 set(['http://foo.com', 'http://bar.com', 'http://baz.com']),
64 set(p.url for p in page_set_b.pages)) 62 set(p.url for p in page_set_b.pages))
65 for p in page_set_b.pages: 63 for p in page_set_b.pages:
66 self.assertIs(page_set_b, p.page_set) 64 self.assertIs(page_set_b, p.page_set)
OLDNEW
« no previous file with comments | « tools/telemetry/telemetry/page/__init__.py ('k') | tools/telemetry/telemetry/unittest_util/system_stub.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698