Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/user_story/user_story_set.py

Issue 1005903004: Revert of Refactor serving_dirs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | tools/telemetry/telemetry/util/cloud_storage.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_set.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_set.py b/tools/telemetry/telemetry/user_story/user_story_set.py
index e68b4ea685c7399517e6c308ee25329a83193db6..7db2947efcc95675cab52b87f96fb2eb24efa9c5 100644
--- a/tools/telemetry/telemetry/user_story/user_story_set.py
+++ b/tools/telemetry/telemetry/user_story/user_story_set.py
@@ -32,9 +32,6 @@
Web Page Replay's archive data. Valid values are: None,
PUBLIC_BUCKET, PARTNER_BUCKET, or INTERNAL_BUCKET (defined
in telemetry.util.cloud_storage).
- serving_dirs: A set of paths, relative to self.base_dir, to directories
- containing hash files for non-wpr archive data stored in cloud
- storage.
"""
self.user_stories = []
self._archive_data_file = archive_data_file
@@ -79,11 +76,7 @@
@property
def serving_dirs(self):
- all_serving_dirs = self._serving_dirs.copy()
- for user_story in self.user_stories:
- if user_story.serving_dir:
- all_serving_dirs.add(user_story.serving_dir)
- return all_serving_dirs
+ return self._serving_dirs
@property
def archive_data_file(self):
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | tools/telemetry/telemetry/util/cloud_storage.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698