chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h - Issue 1005873012: Makes bookmark menu lazily create menus and removes limits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review feedback Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

index 86ea7e941b98e9269e237eae1c9f6f3562516428..5c7800834b5883d5dc8a0f991254d17a6fb280ad 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

@@ -112,6 +112,7 @@ class BookmarkMenuController : public bookmarks::BaseBookmarkModelObserver,

bool* has_mnemonics,

views::MenuButton** button) override;

int GetMaxWidthForMenu(views::MenuItemView* view) override;

+ void WillShowMenu(views::MenuItemView* menu) override;

// bookmarks::BaseBookmarkModelObserver:

void BookmarkModelChanged() override;