Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.h

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/wrench_menu_model.h
diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.h b/chrome/browser/ui/toolbar/wrench_menu_model.h
index da4c431dd556b5c5bbd219f2fd6971a21da23625..aa6e8b2ea798efcdbbf94a77ed0f469f9b2a7197 100644
--- a/chrome/browser/ui/toolbar/wrench_menu_model.h
+++ b/chrome/browser/ui/toolbar/wrench_menu_model.h
@@ -128,13 +128,7 @@ class WrenchMenuModel : public ui::SimpleMenuModel,
public TabStripModelObserver,
public content::NotificationObserver {
public:
- // Range of command ID's to use for the items representing bookmarks in the
- // bookmark menu, must not overlap with that for recent tabs submenu.
- static const int kMinBookmarkCommandId = 1;
- static const int kMaxBookmarkCommandId = 1000;
-
- // Range of command ID's to use for the items in the recent tabs submenu, must
- // not overlap with that for bookmarks.
+ // Range of command IDs to use for the items in the recent tabs submenu.
static const int kMinRecentTabsCommandId = 1001;
static const int kMaxRecentTabsCommandId = 1200;
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698