Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
index b01a8c08b81287414939eca6e5c9ca01e161a9c5..02d3a11e00b2f3a7b13a5d50616de7be11008b00 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc
@@ -31,9 +31,7 @@ BookmarkMenuController::BookmarkMenuController(Browser* browser,
const BookmarkNode* node,
int start_child_index,
bool for_drop)
- : menu_delegate_(
- new BookmarkMenuDelegate(browser, page_navigator, parent, 1,
- kint32max)),
+ : menu_delegate_(new BookmarkMenuDelegate(browser, page_navigator, parent)),
node_(node),
observer_(NULL),
for_drop_(for_drop),
@@ -186,6 +184,10 @@ int BookmarkMenuController::GetMaxWidthForMenu(MenuItemView* view) {
return menu_delegate_->GetMaxWidthForMenu(view);
}
+void BookmarkMenuController::WillShowMenu(MenuItemView* menu) {
+ menu_delegate_->WillShowMenu(menu);
+}
+
void BookmarkMenuController::BookmarkModelChanged() {
if (!menu_delegate_->is_mutating_model())
menu()->Cancel();

Powered by Google App Engine
This is Rietveld 408576698