Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

Issue 1005873012: Makes bookmark menu lazily create menus and removes limits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review feedback Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 bool CanDrag(views::MenuItemView* menu) override; 105 bool CanDrag(views::MenuItemView* menu) override;
106 void WriteDragData(views::MenuItemView* sender, 106 void WriteDragData(views::MenuItemView* sender,
107 ui::OSExchangeData* data) override; 107 ui::OSExchangeData* data) override;
108 int GetDragOperations(views::MenuItemView* sender) override; 108 int GetDragOperations(views::MenuItemView* sender) override;
109 views::MenuItemView* GetSiblingMenu(views::MenuItemView* menu, 109 views::MenuItemView* GetSiblingMenu(views::MenuItemView* menu,
110 const gfx::Point& screen_point, 110 const gfx::Point& screen_point,
111 views::MenuAnchorPosition* anchor, 111 views::MenuAnchorPosition* anchor,
112 bool* has_mnemonics, 112 bool* has_mnemonics,
113 views::MenuButton** button) override; 113 views::MenuButton** button) override;
114 int GetMaxWidthForMenu(views::MenuItemView* view) override; 114 int GetMaxWidthForMenu(views::MenuItemView* view) override;
115 void WillShowMenu(views::MenuItemView* menu) override;
115 116
116 // bookmarks::BaseBookmarkModelObserver: 117 // bookmarks::BaseBookmarkModelObserver:
117 void BookmarkModelChanged() override; 118 void BookmarkModelChanged() override;
118 119
119 private: 120 private:
120 // BookmarkMenuController deletes itself as necessary. 121 // BookmarkMenuController deletes itself as necessary.
121 ~BookmarkMenuController() override; 122 ~BookmarkMenuController() override;
122 123
123 scoped_ptr<views::MenuRunner> menu_runner_; 124 scoped_ptr<views::MenuRunner> menu_runner_;
124 125
(...skipping 13 matching lines...) Expand all
138 139
139 // The bookmark bar. This is only non-null if we're showing a menu item for a 140 // The bookmark bar. This is only non-null if we're showing a menu item for a
140 // folder on the bookmark bar and not for drop, or if the BookmarkBarView has 141 // folder on the bookmark bar and not for drop, or if the BookmarkBarView has
141 // been destroyed before the menu. 142 // been destroyed before the menu.
142 BookmarkBarView* bookmark_bar_; 143 BookmarkBarView* bookmark_bar_;
143 144
144 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController); 145 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController);
145 }; 146 };
146 147
147 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 148 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698