Chromium Code Reviews
DescriptionDo not pass use_prebuilt_mojo_shell to gn.
Should fix "Chromium Mojo Linux"'s "gn gen" error:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/8374/steps/gn/logs/stdio
ERROR at the command-line "--args":1:25: Build argument has no effect.
use_prebuilt_mojo_shell=true is_debug=false cpu_arch="x64" use_goma=true goma_dir="/mnt/data/b/build/goma"
^---
The variable "use_prebuilt_mojo_shell" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
Removing the command-line override of the gn arg should be okay, now that
a Mojo roll that added the self-contained arg logic to
mojo/public/mojo.gni <https://codereview.chromium.org/917433003>.
BUG=NONE
TEST=No gn gen errors.
R=ppi@chromium.org,dpranke@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294406
Patch Set 1 #Patch Set 2 : Rename 'Run apptests' to 'app_tests'. #
Messages
Total messages: 7 (1 generated)
|
|||||||||||||||||||||||||||||||||||||