Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1003453002: Do not pass use_prebuilt_mojo_shell to gn. (Closed)

Created:
5 years, 9 months ago by msw
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, ppi
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, jamesr, blundell, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Do not pass use_prebuilt_mojo_shell to gn. Should fix "Chromium Mojo Linux"'s "gn gen" error: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/8374/steps/gn/logs/stdio ERROR at the command-line "--args":1:25: Build argument has no effect. use_prebuilt_mojo_shell=true is_debug=false cpu_arch="x64" use_goma=true goma_dir="/mnt/data/b/build/goma" ^--- The variable "use_prebuilt_mojo_shell" was set as a build argument but never appeared in a declare_args() block in any buildfile. Removing the command-line override of the gn arg should be okay, now that a Mojo roll that added the self-contained arg logic to mojo/public/mojo.gni <https://codereview.chromium.org/917433003>;. BUG=NONE TEST=No gn gen errors. R=ppi@chromium.org,dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294406

Patch Set 1 #

Patch Set 2 : Rename 'Run apptests' to 'app_tests'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_mojo.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_mojo.expected/full_chromium_mojo_Chromium_Mojo_Linux.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
msw
Hey Dirk and Przemyslaw, please take a look; thanks! (I get a *lot* of seemingly ...
5 years, 9 months ago (2015-03-11 18:16:13 UTC) #1
Dirk Pranke
This change looks fine, if you actually want us to not use the prebuilt mojo ...
5 years, 9 months ago (2015-03-11 18:52:45 UTC) #2
msw
On 2015/03/11 18:52:45, Dirk Pranke wrote: > This change looks fine, if you actually want ...
5 years, 9 months ago (2015-03-11 19:04:58 UTC) #3
Dirk Pranke
Ah, okay, I hadn't seen that other change. lgtm.
5 years, 9 months ago (2015-03-11 19:10:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003453002/20001
5 years, 9 months ago (2015-03-11 19:11:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:15:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294406

Powered by Google App Engine
This is Rietveld 408576698