Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 921763002: Prepare //build/module_args/mojo.gni for upcoming Mojo rolls (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare //build/module_args/mojo.gni for upcoming Mojo rolls These variables will start being used by BUILD.gn files in the Mojo repo shortly, so ensure that Chromium has the right values set for them. Committed: https://crrev.com/ac3f7624d4f83ba067e16e9fc49c4ad87fa38841 Cr-Commit-Position: refs/heads/master@{#315991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/module_args/mojo.gni View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
blundell
Whoever gets to it first wins. Thanks!
5 years, 10 months ago (2015-02-12 14:25:20 UTC) #2
scottmg
It looks like there are references to https://code.google.com/p/chromium/codesearch#search/&q=use_prebuilt_mojo_shell&sq=package:chromium&type=cs . Are those going to break in ...
5 years, 10 months ago (2015-02-12 16:29:49 UTC) #3
blundell
On 2015/02/12 16:29:49, scottmg wrote: > It looks like there are references to > https://code.google.com/p/chromium/codesearch#search/&q=use_prebuilt_mojo_shell&sq=package:chromium&type=cs ...
5 years, 10 months ago (2015-02-12 16:41:55 UTC) #4
scottmg
Sorry, not enough coffee yet, didn't notice that was commented out. lgtm
5 years, 10 months ago (2015-02-12 16:45:49 UTC) #5
blundell
On 2015/02/12 16:45:49, scottmg wrote: > Sorry, not enough coffee yet, didn't notice that was ...
5 years, 10 months ago (2015-02-12 16:46:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921763002/1
5 years, 10 months ago (2015-02-12 16:47:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 16:51:15 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:51:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac3f7624d4f83ba067e16e9fc49c4ad87fa38841
Cr-Commit-Position: refs/heads/master@{#315991}

Powered by Google App Engine
This is Rietveld 408576698