scripts/slave/recipes/chromium_mojo.py - Issue 1003453002: Do not pass use_prebuilt_mojo_shell to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_mojo.py

Issue 1003453002: Do not pass use_prebuilt_mojo_shell to gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Rename 'Run apptests' to 'app_tests'. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/chromium_mojo.py

diff --git a/scripts/slave/recipes/chromium_mojo.py b/scripts/slave/recipes/chromium_mojo.py

index 75bdc57fe330ea2082efed11886a847e3ee16982..edb0df489fc99b9e749a4a5c0a2260e44d8efb1f 100644

--- a/scripts/slave/recipes/chromium_mojo.py

+++ b/scripts/slave/recipes/chromium_mojo.py

@@ -16,7 +16,6 @@ BUILDERS = freeze({

'chromium.mojo': {

'builders': {

'Chromium Mojo Linux': {

- 'chromium_apply_config': ['gn_use_prebuilt_mojo_shell'],

'chromium_config_kwargs': {

'BUILD_CONFIG': 'Release',

'TARGET_PLATFORM': 'linux',

@@ -31,7 +30,7 @@ def _RunApptests(api):

'apptest_runner.py')

apptest_config = api.path['checkout'].join('mojo', 'tools',

'data', 'apptests')

- api.python('run apptests', apptest_runner,

+ api.python('app_tests', apptest_runner,

[apptest_config, api.chromium.output_dir])