Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917433003: Update mojo sdk to rev 1027d24a1f68c6d10b7539b32114f1272b2cc9f1 (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 1027d24a1f68c6d10b7539b32114f1272b2cc9f1 Also apply mojo 847492f4cfc15daf55fde59372a84c677689eb55 (https://codereview.chromium.org/919443002/). Also apply mojo e9827c5507b1c0435f8a4e9987ff5bd044b21ac9 (https://codereview.chromium.org/915953002/). Also add an effectively blank //build/module_args/mojo.gni. TBR=jamesr@chromium.org NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win8_chromium_gn_rel Committed: https://crrev.com/f84e88c1edd40b03ed85b2858a8b5769f35ad34b Cr-Commit-Position: refs/heads/master@{#315802}

Patch Set 1 #

Patch Set 2 : Apply 847492f4cfc15daf55fde59372a84c677689eb55 (https://codereview.chromium.org/919443002/). #

Patch Set 3 : Apply e9827c5507b1c0435f8a4e9987ff5bd044b21ac9 (https://codereview.chromium.org/915953002/) #

Patch Set 4 : Add //build/module_args/mojo.gni. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -78 lines) Patch
A build/module_args/mojo.gni View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/callback.h View 3 chunks +22 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/callback_internal.h View 2 chunks +27 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/template_util.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/bounds_checker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/buffer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/cpp/bindings/tests/callback_unittest.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/logging.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/tests/logging_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/dart/src/application.dart View 4 chunks +36 lines, -22 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/codec.js View 7 chunks +15 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/js/validator.js View 3 chunks +11 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/parse/translate.py View 5 chunks +34 lines, -14 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/parse/translate_unittest.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917433003/40001
5 years, 10 months ago (2015-02-11 05:49:24 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/7093)
5 years, 10 months ago (2015-02-11 05:54:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917433003/60001
5 years, 10 months ago (2015-02-11 06:12:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/9632)
5 years, 10 months ago (2015-02-11 06:19:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917433003/60001
5 years, 10 months ago (2015-02-11 07:16:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/9644)
5 years, 10 months ago (2015-02-11 07:23:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917433003/60001
5 years, 10 months ago (2015-02-11 16:55:15 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-11 18:54:38 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 18:59:28 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f84e88c1edd40b03ed85b2858a8b5769f35ad34b
Cr-Commit-Position: refs/heads/master@{#315802}

Powered by Google App Engine
This is Rietveld 408576698