Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1001183003: Add minimum size for using distance fields. (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add minimum size for using distance fields. Since we're not scaling down as far, we can increase the base sizes a little. Also darken debug text colors to get better value comparison with black. BUG=skia:3541 Committed: https://skia.googlesource.com/skia/+/24ba00825092be0d400074e0121ffc7221950dd9

Patch Set 1 #

Patch Set 2 : Disable debug text; darken red debug color #

Patch Set 3 : Tweak dftext sharpening and smallest size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jvanverth1
5 years, 9 months ago (2015-03-16 18:26:59 UTC) #2
egdaniel
lgtm
5 years, 9 months ago (2015-03-16 18:37:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001183003/20001
5 years, 9 months ago (2015-03-17 13:23:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001183003/40001
5 years, 9 months ago (2015-03-19 18:29:25 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 18:34:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/24ba00825092be0d400074e0121ffc7221950dd9

Powered by Google App Engine
This is Rietveld 408576698