Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: src/gpu/GrDistanceFieldTextContext.cpp

Issue 1001183003: Add minimum size for using distance fields. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Tweak dftext sharpening and smallest size Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/effects/GrDistanceFieldTextureEffect.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDistanceFieldTextContext.cpp
diff --git a/src/gpu/GrDistanceFieldTextContext.cpp b/src/gpu/GrDistanceFieldTextContext.cpp
index 180c506e33d271176a2ea9e3325f63cf69279882..7e93892a687c4a607dc2e9fcad6a0ad588a40d14 100755
--- a/src/gpu/GrDistanceFieldTextContext.cpp
+++ b/src/gpu/GrDistanceFieldTextContext.cpp
@@ -32,10 +32,11 @@
SK_CONF_DECLARE(bool, c_DumpFontCache, "gpu.dumpFontCache", false,
"Dump the contents of the font cache before every purge.");
-static const int kSmallDFFontSize = 32;
-static const int kSmallDFFontLimit = 32;
-static const int kMediumDFFontSize = 72;
-static const int kMediumDFFontLimit = 72;
+static const int kMinDFFontSize = 18;
+static const int kSmallDFFontSize = 40;
+static const int kSmallDFFontLimit = 40;
+static const int kMediumDFFontSize = 81;
+static const int kMediumDFFontLimit = 81;
static const int kLargeDFFontSize = 162;
static const int kVerticesPerGlyph = 4;
@@ -88,8 +89,9 @@ bool GrDistanceFieldTextContext::canDraw(const SkPaint& paint, const SkMatrix& v
SkScalar maxScale = viewMatrix.getMaxScale();
SkScalar scaledTextSize = maxScale*paint.getTextSize();
+ // Hinted text looks far better at small resolutions
// Scaling up beyond 2x yields undesireable artifacts
- if (scaledTextSize > 2*kLargeDFFontSize) {
+ if (scaledTextSize < kMinDFFontSize || scaledTextSize > 2*kLargeDFFontSize) {
return false;
}
@@ -142,22 +144,22 @@ inline void GrDistanceFieldTextContext::init(GrRenderTarget* rt, const GrClip& c
fTextRatio = textSize / kSmallDFFontSize;
fSkPaint.setTextSize(SkIntToScalar(kSmallDFFontSize));
#if DEBUG_TEXT_SIZE
- fSkPaint.setColor(SkColorSetARGB(0xFF, 0x00, 0x00, 0xFF));
- fPaint.setColor(GrColorPackRGBA(0x00, 0x00, 0xFF, 0xFF));
+ fSkPaint.setColor(SkColorSetARGB(0xFF, 0x00, 0x00, 0x7F));
+ fPaint.setColor(GrColorPackRGBA(0x00, 0x00, 0x7F, 0xFF));
#endif
} else if (scaledTextSize <= kMediumDFFontLimit) {
fTextRatio = textSize / kMediumDFFontSize;
fSkPaint.setTextSize(SkIntToScalar(kMediumDFFontSize));
#if DEBUG_TEXT_SIZE
- fSkPaint.setColor(SkColorSetARGB(0xFF, 0x00, 0xFF, 0x00));
- fPaint.setColor(GrColorPackRGBA(0x00, 0xFF, 0x00, 0xFF));
+ fSkPaint.setColor(SkColorSetARGB(0xFF, 0x00, 0x3F, 0x00));
+ fPaint.setColor(GrColorPackRGBA(0x00, 0x3F, 0x00, 0xFF));
#endif
} else {
fTextRatio = textSize / kLargeDFFontSize;
fSkPaint.setTextSize(SkIntToScalar(kLargeDFFontSize));
#if DEBUG_TEXT_SIZE
- fSkPaint.setColor(SkColorSetARGB(0xFF, 0xFF, 0x00, 0x00));
- fPaint.setColor(GrColorPackRGBA(0xFF, 0x00, 0x00, 0xFF));
+ fSkPaint.setColor(SkColorSetARGB(0xFF, 0x7F, 0x00, 0x00));
+ fPaint.setColor(GrColorPackRGBA(0x7F, 0x00, 0x00, 0xFF));
#endif
}
« no previous file with comments | « no previous file | src/gpu/effects/GrDistanceFieldTextureEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698