Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1000373002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]* (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, tzik, avayvod+watch_chromium.org, dgrogan, nasko+codewatch_chromium.org, jam, nhiroki, feature-media-reviews_chromium.org, johnme+watch_chromium.org, darin-cc_chromium.org, cmumford, Michael van Ouwerkerk, piman+watch_chromium.org, peter+watch_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]* BUG=466848 Committed: https://crrev.com/4c27d0473be08853f38b5031c660bfb3ae6158d4 Cr-Commit-Position: refs/heads/master@{#321215}

Patch Set 1 #

Patch Set 2 : rely on DCHECK_CURRENTLY_ON's message #

Patch Set 3 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -247 lines) Patch
M content/browser/fileapi/chrome_blob_storage_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 24 chunks +34 lines, -34 lines 0 comments Download
M content/browser/frame_host/cross_site_transferring_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/histogram_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/histogram_synchronizer.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/temporary_file_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/browser/media/media_internals_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_proxy.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M content/browser/media/webrtc_identity_store.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M content/browser/media/webrtc_identity_store_backend.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M content/browser/media/webrtc_internals.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M content/browser/media/webrtc_internals_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/pepper_flash_settings_helper_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/plugin_process_host_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/power_profiler/power_profiler_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_x11.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/profiler_controller_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/push_messaging/push_messaging_router.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Mostyn Bramley-Moore
@Charlie: PTAL. (I'm trying to spread the load around content/OWNERS a bit, so there are ...
5 years, 9 months ago (2015-03-13 12:26:53 UTC) #2
Charlie Reis
LGTM
5 years, 9 months ago (2015-03-18 18:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000373002/20001
5 years, 9 months ago (2015-03-18 19:47:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/49075) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-18 19:51:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1000373002/40001
5 years, 9 months ago (2015-03-18 20:05:12 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-18 21:48:04 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 21:48:51 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c27d0473be08853f38b5031c660bfb3ae6158d4
Cr-Commit-Position: refs/heads/master@{#321215}

Powered by Google App Engine
This is Rietveld 408576698