content/browser/frame_host/interstitial_page_impl.cc - Issue 1000373002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 1000373002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/cross_site_transferring_request.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/interstitial_page_impl.cc

diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc

index 1324c7321a9073ec4348cb5e7388c043f817f5d1..197d9d4294179845bb206e09cfd715aec7577c86 100644

--- a/content/browser/frame_host/interstitial_page_impl.cc

+++ b/content/browser/frame_host/interstitial_page_impl.cc

@@ -781,8 +781,7 @@ void InterstitialPageImpl::OnNavigatingAwayOrTabClosing() {

void InterstitialPageImpl::TakeActionOnResourceDispatcher(

ResourceRequestAction action) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)) <<

- "TakeActionOnResourceDispatcher should be called on the main thread.";

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (action == CANCEL || action == RESUME) {

if (resource_dispatcher_host_notified_)