content/browser/gpu/browser_gpu_channel_host_factory.cc - Issue 1000373002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/browser_gpu_channel_host_factory.cc

Issue 1000373002: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[f-p]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/geolocation_provider_impl.cc ('k') | content/browser/gpu/browser_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/browser_gpu_channel_host_factory.cc

diff --git a/content/browser/gpu/browser_gpu_channel_host_factory.cc b/content/browser/gpu/browser_gpu_channel_host_factory.cc

index d938b4ba918b5842724a382ad62b3573ca42c26b..16ce7584d032bb7c7c65f9cbf2aff206cc7aa205 100644

--- a/content/browser/gpu/browser_gpu_channel_host_factory.cc

+++ b/content/browser/gpu/browser_gpu_channel_host_factory.cc

@@ -452,7 +452,7 @@ void BrowserGpuChannelHostFactory::GpuChannelEstablished() {

void BrowserGpuChannelHostFactory::AddFilterOnIO(

int host_id,

scoped_refptr<IPC::MessageFilter> filter) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

GpuProcessHost* host = GpuProcessHost::FromID(host_id);

if (host)

@@ -503,7 +503,7 @@ void BrowserGpuChannelHostFactory::CreateGpuMemoryBuffer(

int client_id,

int32 surface_id,

const CreateGpuMemoryBufferCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

GpuProcessHost* host = GpuProcessHost::FromID(gpu_host_id_);

if (!host) {

@@ -538,7 +538,7 @@ void BrowserGpuChannelHostFactory::DestroyGpuMemoryBufferOnIO(

gfx::GpuMemoryBufferId id,

int client_id,

int32 sync_point) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

GpuProcessHost* host = GpuProcessHost::FromID(gpu_host_id_);

if (!host)

@@ -550,7 +550,7 @@ void BrowserGpuChannelHostFactory::DestroyGpuMemoryBufferOnIO(

void BrowserGpuChannelHostFactory::OnGpuMemoryBufferCreated(

uint32 request_id,

const gfx::GpuMemoryBufferHandle& handle) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

CreateGpuMemoryBufferCallbackMap::iterator iter =

create_gpu_memory_buffer_requests_.find(request_id);