Issue 98683002: Change other futures to also have timeout take a named parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98683002: Change other futures to also have timeout take a named parameter. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen

Modified:
7 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Change other futures to also have timeout take a named parameter. Committed: https://code.google.com/p/dart/source/detail?r=30792

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	pkg/barback/lib/src/cancelable_future.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/substitute_future.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/value_future.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/error_group.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/lib/async/future_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/lib/async/future_value_chain4_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

Future.timeout is implemented in more places. Changing them all to named parameter. TBR.

7 years ago (2013-12-02 09:13:08 UTC) #1

Lasse Reichstein Nielsen

Committed patchset #1 manually as r30792 (presubmit successful).

7 years ago (2013-12-02 09:13:59 UTC) #2

Message was sent while issue was closed.

LGTM.