Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: pkg/barback/lib/src/cancelable_future.dart

Issue 98683002: Change other futures to also have timeout take a named parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/src/substitute_future.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/cancelable_future.dart
diff --git a/pkg/barback/lib/src/cancelable_future.dart b/pkg/barback/lib/src/cancelable_future.dart
index 4454f5cf2b383f143f082121dc0ce668d743123a..84c19f148e605903d8d9be13e38972f70f12248a 100644
--- a/pkg/barback/lib/src/cancelable_future.dart
+++ b/pkg/barback/lib/src/cancelable_future.dart
@@ -32,8 +32,8 @@ class CancelableFuture<T> implements Future<T> {
Future then(onValue(T value), {Function onError}) =>
_completer.future.then(onValue, onError: onError);
Future<T> whenComplete(action()) => _completer.future.whenComplete(action);
- Future timeout(Duration timeLimit, [void onTimeout()]) =>
- _completer.future.timeout(timeLimit, onTimeout);
+ Future timeout(Duration timeLimit, {void onTimeout()}) =>
+ _completer.future.timeout(timeLimit, onTimeout: onTimeout);
/// Cancels this future.
void cancel() {
_canceled = true;
« no previous file with comments | « no previous file | pkg/scheduled_test/lib/src/substitute_future.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698