sdk/lib/_internal/pub/lib/src/error_group.dart - Issue 98683002: Change other futures to also have timeout take a named parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/error_group.dart

Issue 98683002: Change other futures to also have timeout take a named parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/pub/lib/src/error_group.dart

diff --git a/sdk/lib/_internal/pub/lib/src/error_group.dart b/sdk/lib/_internal/pub/lib/src/error_group.dart

index ae0410f21c742192def5246849a01882187bd303..52a284c8049a422e7cf291a2f8c864d4b9ab8167 100644

--- a/sdk/lib/_internal/pub/lib/src/error_group.dart

+++ b/sdk/lib/_internal/pub/lib/src/error_group.dart

@@ -194,9 +194,9 @@ class _ErrorGroupFuture implements Future {

return _completer.future.whenComplete(action);

}

- Future timeout(Duration timeLimit, [void onTimeout()]) {

+ Future timeout(Duration timeLimit, {void onTimeout()}) {

_hasListeners = true;

- return _completer.future.timeout(timeLimit, onTimeout);

+ return _completer.future.timeout(timeLimit, onTimeout: onTimeout);

}

Stream asStream() {

« no previous file with comments | « pkg/scheduled_test/lib/src/value_future.dart ('k') | tests/lib/async/future_test.dart » ('j') | no next file with comments »