Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: pkg/scheduled_test/lib/src/substitute_future.dart

Issue 98683002: Change other futures to also have timeout take a named parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/barback/lib/src/cancelable_future.dart ('k') | pkg/scheduled_test/lib/src/value_future.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/substitute_future.dart
diff --git a/pkg/scheduled_test/lib/src/substitute_future.dart b/pkg/scheduled_test/lib/src/substitute_future.dart
index d30c9364e886ac4660eab75713b6be93cd90b59c..5c916895a883fe3d4246949cf24a261d7bb865c9 100644
--- a/pkg/scheduled_test/lib/src/substitute_future.dart
+++ b/pkg/scheduled_test/lib/src/substitute_future.dart
@@ -29,8 +29,8 @@ class SubstituteFuture<T> implements Future<T> {
Future then(onValue(T value), {Function onError}) =>
_completer.future.then(onValue, onError: onError);
Future<T> whenComplete(action()) => _completer.future.whenComplete(action);
- Future timeout(Duration timeLimit, [void onTimeout()]) =>
- _completer.future.timeout(timeLimit, onTimeout);
+ Future timeout(Duration timeLimit, {void onTimeout()}) =>
+ _completer.future.timeout(timeLimit, onTimeout: onTimeout);
/// Substitutes [newFuture] for the currently wrapped [Future], which is
/// returned.
« no previous file with comments | « pkg/barback/lib/src/cancelable_future.dart ('k') | pkg/scheduled_test/lib/src/value_future.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698