Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 904603004: rename completion constants and cleanup comment (Closed)

Created:
5 years, 10 months ago by danrubel
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -115 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 6 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/combinator_computer_test.dart View 2 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 33 chunks +36 lines, -36 lines 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 20 chunks +22 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 10 months ago (2015-02-05 19:46:15 UTC) #2
scheglov
LGTM
5 years, 10 months ago (2015-02-05 19:48:43 UTC) #3
danrubel
5 years, 10 months ago (2015-02-05 19:50:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698